search

kartik-venugopal / aural-player

An audio player for macOS, inspired by Winamp.
MIT License
822 stars 44 forks source link

FLAC Support #7

Closed jicksta closed 5 years ago

jicksta commented 6 years ago

This is an ideal audio player for me in many ways, except that my main use-case involves mostly FLAC audio. Sorry, I don't have the time or stack proficiency to add this in myself.

I noticed Aural Player uses AVFoundation for playback. I couldn't find anything online about FLAC with AVFoundation, so I assume that FLAC support would entail the use of a third-party library. This may involve re-writing of or indirection around the currently used AVFoundation APIs, so I understand if this is out-of-scope for a minimalist project. As for third-party audio engines, my cursory searching led me to OrigamiEngine, which also seems to standardize metadata access across formats too.

Thanks for the work on Aural Player so far! If this is out-of-scope, perhaps someone in the community could take this up?

kartik-venugopal commented 6 years ago

Hi @jicksta ,

Thanks for your great feedback on and interest in the Aural Player project.

Yes, you're right, this was intended as a "minimalist" project, not as a comprehensive audio player that plays everything. From what you've said about FLAC and from what I know, that definitely seems like it would require too much reworking to support, so I will have to pass on the responsibility for now.

I would love for someone to fork Aural Player and add the FLAC support (another good one to have would be WMA).

Best regards, maculateConception

kartik-venugopal commented 5 years ago

Hi @jicksta ,

I discovered today that my player can, in fact, play FLAC files, right out of the box without any special modifications.

I have also figured out how to include LibAV in my player, which can transcode between other formats like Ogg, Vorbis, WMA, etc, and happen to be adding that support right now. So, pretty soon, I will put out a release of my app that can play damn near everything.

Thought I'd let you know because you had mentioned that Aural Player is an ideal player for your needs.

Cheers !

grogcw commented 5 years ago

Hi ! I've read this thread, and I'd like to back jicksta up on this neat feature :)

Cheers !

kartik-venugopal commented 5 years ago

Hi grogcw, thanks for the message.

Yes, my player can definitely play FLAC files. I was unaware of this before, but today, accidentally discovered this :)

I will soon put out a release that allows users to add FLAC files to the playlist.

Cheers !

grogcw commented 5 years ago

I'm glad to read that ! I started using your player yesterday and I love it already !

I'd like it to be a little more compact width-wise tho, but I'll open another issue regarding the GUI.

Please continue your great work, you're on the right track !

Cheers !

kartik-venugopal commented 5 years ago

Cool ! Thanks for the great feedback.

BTW, I realized that I'm running macOS 10.14, and native FLAC support was introduced in 10.13 (High Sierra). So, (in the next upcoming release) Aural Player will natively play FLAC on High Sierra and Mojave. If you have an older OS, it will transcode it to another format like AIFF and play the transcoded file.

So, either way, FLAC support is coming for sure :)

Thanks again, and yes, do file that issue.

kartik-venugopal commented 5 years ago

I'm glad to read that ! I started using your player yesterday and I love it already !

I'd like it to be a little more compact width-wise tho, but I'll open another issue regarding the GUI.

Please continue your great work, you're on the right track !

Cheers !

Hi, I've been working hard to get the new release out, that will play many new formats including FLAC. At this point, the implementation is pretty much done and I am doing extensive testing. So, you can expect a release some time in the next few days.

kartik-venugopal commented 5 years ago

@jicksta @grogcw

Released with support for FLAC and many more formats ! Download here: