kartik-venugopal / aural-player

An audio player for macOS, inspired by Winamp.
MIT License
819 stars 44 forks source link

Improve FFmpeg error handling (I/O errors) #74

Open sirlaurie opened 8 months ago

sirlaurie commented 8 months ago

Bug:

aural log file too big, it takes up most of space on my disk

screenshot 4

Reason:

I mount NFS drive on my macOS and use aural load music from NFS drive. when network disconnet, the NFS drive could not access by aural, it will generate error log constantly.

Suggest:

  1. limit max size of log file
  2. optimize file loading logic
kartik-venugopal commented 8 months ago

Thanks for the bug report! Will take a look.

kartik-venugopal commented 8 months ago

I did quite a bit of investigation and was able to reproduce the issue. This issue requires a carefully thought out solution in terms of error handling. I want to make sure to implement a reliable solution, so it will take me some time.

sirlaurie commented 8 months ago

it's not hurry. maybe fix it in version 4.0?

sirlaurie commented 3 months ago

Hi, sorry to bother, any news from 4.0? can I build it from source? I am not a swift developer, and not familiar with building xcode project. It will be great if you provide a guide about how to build it from scratch😀

kartik-venugopal commented 3 months ago

Aural-4.0.zip

Hi @sirlaurie , I have attached a fresh new build of v4.0 for you. I have just not been able to release it yet because I've been extremely busy with other things, but I hope to release it in the next few months.

Please note that the attached app version is not complete ... some features will not work. There may be bugs or crashes, but the core features of it do work.

If you want to build it yourself in the future, all you have to do is download Xcode version 15.3, install the Command Line Tools 15.3, and then run Product > Archive and export a copy of the app.

You can also ask me for updated builds if you want. Cheers!

kartik-venugopal commented 3 months ago

@sirlaurie - FYI, I have released a "preview" build of v4.0.0: here.

It has a few small fixes compared to the build I sent you earlier 😄

sirlaurie commented 3 months ago

Wow, a big change! I noticed that "preview" release has fixed music loading bug. I have some wav file couldn't load successfully by aural before but can be played by ffplay, now it's all loaded successfully!

Love it!