search

kartikey54 / VaccineAvailabilityNotifier

534 stars 334 forks source link

Add .env to gitignore file #54

Closed sohamsshah closed 3 years ago

sohamsshah commented 3 years ago

Adding .env to production isn't a good practice. Would like to RAISE a PR for the same.

P.S. - Loved your project :)

shantnu-agarwal commented 3 years ago

The purpose of the env in this project is to enable people to configure their own email, age, pincode, etc. Adding the ENV to gitignore would defeat the purpose of making this project accessible to a large set of people who wouldn't know how to set up a env file on their own.

As per me, this is a non-issue.

sohamsshah commented 3 years ago

Fine, makes sense. Though, I suppose this is being used by developers; so a good readme with details for .env would do the purpose. Anyways, no problem.

P.S. - In open source, never thumbs down someone's comment. Respect opinions to make it a positive place to work at. Thanks