search

kartikk221 / live-directory

A Simple-To-Use Dynamic Template Content Manager For Webservers
MIT License
12 stars 5 forks source link

added typescript types #3

Closed ImLunaHey closed 2 years ago

ImLunaHey commented 2 years ago

Closes #2

I think types also needs to be updated in package.json

ImLunaHey commented 2 years ago

Just noticed this is missing the events typed for the on and off methods for the event emitter. I can fix these if you want this to be merged. If not I'll close it and wait for v3.0.0.

kartikk221 commented 2 years ago

I've closed this pull request for now, so feel free to make your changes in your fork. I'd be more than glad to merge a PR after 3.0.0 is out as conflicts/changes will be clearer.

ImLunaHey commented 2 years ago

Do you have an ETA on 3.0.0 I noticed there's no branch for it?

kartikk221 commented 2 years ago

I'm only in the planning stages for it right now and the breaking changes will mostly be that LiveDirectory will receive the ability to fine tune things such as which files are cached in memory/which files are streamed from disk along with other dependent properties such as etags etc. I would say that the ETA is 1 - 2 weeks.