PA Review: User Authorization - Githubissues

kartikvips / fable

3 stars 0 forks source link

PA Review: User Authorization #2

Open kartikvips opened 6 years ago

kartikvips commented 6 years ago

[x] Backend: DB, model, controller, views
[x] Redux Loop: ajax, actions, reducer
[x] Presentational Components and Containers
[x] Styling
[x] Smooth, bug-free navigation
[x] Adequate and appropriate seeds

AAlfarho commented 6 years ago

This MVP is almost complete, there are a couple minor details we need to address before moving forward.

[x] If there is an error signing up a user, opening the login modal still displays the errors, we should clear them.
[x] Lets also center the errors.
[x] Going to a random route /#/oweiniouewbrviuwebv should redirect to either /, /login, or /signup.
[ ] (Optional) We should be able to close modals by hitting esc. Lets create a new issue to keep track of this.

Feel free to check the items on this list and assign this issue back to me once the mentioned points are addressed.