kartolo / direct_mail

it's an newsletter sending extension for the TYPO3 CMS
40 stars 115 forks source link

If Statistic is enabled, the links in the newsletter didn't use the domain from the sitelanguage but domain from standardlanguage #279

Open schorsch8878 opened 2 years ago

schorsch8878 commented 2 years ago

Hello, we have a Website with 3 languages. Every language has a own newsletter and a own domain. If Statistic is enabled, the links in the newsletter didn't use the domain from the sitelanguage but domain from standardlanguage. this causes an error.

TYPO3 10.4.20 Direct Mail 7.0.1

Many Thanks

Greetings George

jokumer commented 2 years ago

Hello schorsch8878, I removed the use of sys_domain records when direct_mail was supposed to be compatible with TYPO3v9.5. See https://github.com/kartolo/direct_mail/commit/4c17d51cc80073d7000b217f5b204cc5ffa142d7

How do you configure TYPO3 so that "every language has its own newsletter and its own domain", if not with siteconfiguration. Then your case requires a separate solution, which is not included in direct_mail yet.

schorsch8878 commented 2 years ago

Hello jokumer, I configured this with siteconfig! Without statistics it works very fine. But we need the statistics.

jokumer commented 2 years ago

I will ask in other words, cause I currently can not imaging your setup: How do you configure different domains, for different languages? Give me and other contributors a chance to reproduce your usecase, to find a solution.

schorsch8878 commented 2 years ago

Hello, i configured for each language a domain in the siteconfig. We have 3 languages -> 3 domains and 3 newsletters. Every Newsletter is in a own folder. The site for the newsletter has ist language, so the content for language 2 is in the column for language 2. Sorry I am native german. My english should be better. Bildschirmfoto 2021-12-06 um 11 44 11 Bildschirmfoto 2021-12-06 um 11 48 03

jokumer commented 2 years ago

Now I got it. Didn't know, that you can use a full qualified domain as entry-points for each language in siteconfiguration. Thx, I will have a look

schorsch8878 commented 2 years ago

Thank you! If you need a account to our TYPO3 backend, let me know.

jokumer commented 2 years ago

Thanks, the right way is: I make a fork and install the version you mentioned, in an own TYPO3 instance to reproduce your issue. Then I do some code changes, commit them, and ask you, to verify the changes and test in your environment.

jokumer commented 2 years ago

statistics

If statistic is enabled (means jumpUrl is enabled) all links are rewritten like "mytypo3.tld"+"mid=1&rid=P_1&aC=12345678&jumpurl=1" and will be redirected to the corresponding url.

schorsch8878 commented 2 years ago

Many thanks for your work. The problem is in our site: If the statistics are on, "mytypo3.tld" is from the standard language, not from the system language 2. If i set the mytypo3.tld from the language 2 manually in the link: "mytypo3.tld"+"mid=1&rid=P_1&aC=12345678&jumpurl=1" than it works. With jumpurl off, the link ist correct. i dont know why.

jokumer commented 2 years ago

Can you describe, what the error is? You just wrote "this causes an error"

schorsch8878 commented 2 years ago

Newsletter Domain 2: Link: "domain1.tld"+"mid=1&rid=P_1&aC=12345678&jumpurl=1. --> Browser: Homepage Domain 2 or 404

The Link should look like this:

"domain2.tld"+"mid=1&rid=P_1&aC=12345678&jumpurl=1

When i set this link manually in the browser it works fine.