kartoza / IGRAC-GGIS

https://ggis.un-igrac.org/
GNU Affero General Public License v3.0
4 stars 5 forks source link

Adding extra field in Well and Monitoring Data Record #723

Open EliVolsch opened 2 months ago

EliVolsch commented 2 months ago

Priority: Medium Good afternoon,

We collected new metadata that we would like to include in our wells in the GGMN. It is "DEM elevation based on the GLO_90m dataset" (abbreviation: glo_90m_elev_masl), and we would like to include it under "Location", between "Ground surface elevation" and "Top of well elevation".

onVoYWK

I would like to know if this would be an extra development, or if it can be done under our current contract. It will also entail to update the batch upload file, right?

Kind regards, Claudia

clau1313 commented 1 month ago

Hello there, is there any update about this?

EliVolsch commented 1 month ago

Hi @clau1313 yes we can do it under the current SLA. As @meomancer indicated above it should take about half a day to a full day to implement.

meomancer commented 1 month ago

Hi @clau1313 This updates is ready to be deployed : https://github.com/kartoza/IGRAC-WellAndMonitoringDatabase/pull/136 But my question is, is it also being included on csv (batch and download?)

ods example: wells.ods

clau1313 commented 1 month ago

Hi @meomancer, yes please, it would need to be included in the batch and download files, just as in the example you provided. Thanks!

meomancer commented 1 month ago

Hi @clau1313 This is already released and deployed Could you test it?

clau1313 commented 2 weeks ago

Hi @meomancer, sorry I took so long to test it. I did it last week and now again, but it doesn't seem to work. I am uploading a file (I tried in .xlsx and .ods) but unsuccesfully.

image

The wells are not updated, meaning that the column for "DEM elevation based on the GLO_90m dataset" remains empty.

AFG_wells.ods AFG_wells.xlsx

What can be the problem? Thanks

meomancer commented 2 weeks ago

Hi @clau1313 For the ods, did you convert it from xlsx? Because on ods, your sheetname changed to "General_Information" with underscore. You need to remove the underscore

Selection_050

For excel, are the wells basically already in ggis but you just need to update the DEM? I think we need to update the uploader to be able to updating it, currently it is just for creating

Could you create ticket for that? Because it is different issue

meomancer commented 2 weeks ago

Hi @clau1313 I have updated the batch upload, now it can update the well data Could you try it?

And also it handles the wrong name on your ods, please try with ods

clau1313 commented 1 week ago

Hi @meomancer, it's working, thanks! Also thank you for the other adjustments you made.

Is it possible to modify a bit the text in the tickboxes? I just would like to remove the double negation for clarity purposes:

image

So I propose the following:

Form creates new well. If selected, the process will skip existing wells. Form updates existing well. If selected, the process will skip wells that do not exist.

Thanks!

meomancer commented 1 week ago

Ok @clau1313 I will update it

clau1313 commented 1 week ago

Hi @meomancer, I am trying to update some wells but it doesn't work in some cases. It seems that the problem appears when I don't add all mandatory fields in the wells I want to upload, but only the ID and the new metadata. Can you please change that? if the well is already in the system, it means that all mandatory metadata are already uploaded. So it shouldn't be necessary that I upload them again. Because by giving the ID, and indicating the right organisation, the GGMN should find the well. Right? Thank you.

meomancer commented 1 week ago

Ok sure @clau1313 I will update it on my next igrac time

clau1313 commented 6 days ago

thanks @meomancer