kartoza / ckanext-dalrrd-emc-dcpr

Electronic Metadata Catalog for South Africa's Department of Agriculture, Land Reform and Rural Development
MIT License
4 stars 5 forks source link

System notifications #365

Open ThiashaV opened 2 years ago

ThiashaV commented 2 years ago

Registered users shall be sent relevant system notifications, in accordance with their preference. Notifications shall be sent to user’s email address.

Metadata records shall always be owned by an organization. As such metadata notifications about actions performed on datasets that are not public shall apply only to users that are members of the relevant organization.

gubuntu commented 1 year ago

are none of these working? Did #100 not implement them?

Jeremy-Prior commented 1 year ago

Test account with "Subscribe to notification emails" checked: image

Example of Testing RF73:

For RF74: no notifications are received when a new dataset is published from the same organisation but with a different account. Both accounts are part of the "Test Organization" but when a metadata record is created and published neither account gets a notification.

RF75, RF76, and RF77: This is DCPR request was made to test the system notifications. image This request has been edited and 'approved' by NSIF moderation (for the sake of testing this was done from an admin account) and is awaiting CSI moderation but no notifications have been received on the dashboard or in the associated email address.

Mohab25 commented 1 year ago

@Jeremy-Prior tbh this is quite weird, first the user need to follow a dataset in order to receive notifications about changes made to it even if the user is the creator. the follow isn't automatic, thus notifications weren't received, in the next code merge once a user creates/updates a dataset they will automatically follow it and receive notes about changes, another odd part that this is expected to be a configuration option with CKAN but i had to add it as code. in the following the admin changes a field with the dataset and tester3 is the creator. notification sent

sending emails still needs an SMTP thus this issue still opened.