kartoza / ckanext-dalrrd-emc-dcpr

Electronic Metadata Catalog for South Africa's Department of Agriculture, Land Reform and Rural Development
MIT License
4 stars 5 forks source link

SANSA 1878 mandatory fields should be mandatory in CKAN #386

Closed gubuntu closed 1 year ago

gubuntu commented 1 year ago

At least one field (Acknowledgment) says its mandatory in the tip but does not have a red star. There may be others... Screenshot 2022-11-28 at 14 20 56

Mohab25 commented 1 year ago

removed the text under acknowledgement which is not a mandatory field, add usage field to the schema acknowledgement specific usage

@Jeremy-Prior @seabilwe a last round of tests would be great, reopen if there is something wrong

Jeremy-Prior commented 1 year ago

@Mohab25 "Organisation role" is a mandatory field as it should be but does not have a tip: 1_OrganisationTip

"Maintainer" is correctly implemented as an optional field as per the SANS 1878 document but the tip says it is mandatory: 6_MaintainerTip

"Temporal Reference System Information" is correctly implemented as an optional field but the tip says it is mandatory, I have a suggested change in the screenshot but removing the "This is partly a SANS 1878 mandatory filed" is also fine: 7_TemporalIdentifier

Jeremy-Prior commented 1 year ago

@Mohab25 I'm adding the spelling issues here to as per slack.

Jeremy-Prior commented 1 year ago

Changes applied on testing site.