kartoza / django-bims

https://testing.healthyrivers.kartoza.com
GNU Affero General Public License v3.0
12 stars 19 forks source link

FBIS v2.6: pre-release issues #1834

Closed jeremyshelton closed 4 years ago

jeremyshelton commented 4 years ago

This is a list of issues detected during FRC testing of FBIS v2.6 before circulating the 'release' to the users & partners.

Spatial filters #1823 Some spatial filters seem to have been lost?

Search

Metadata

Problems loading taxon and single site dashboards

Filter names

Search

Adding data

12042019

Number of records Fish

@helendallas @Aneri16

dimasciput commented 4 years ago

Thanks @jeremyshelton! Will address this tomorrow.

jeremyshelton commented 4 years ago

@dimasciput thanks! @helendallas please test the SASS work flows and add any issues to this ticket.

helendallas commented 4 years ago

When validated and non-validated are selected - there are some fish records from Namibia included. @jeremyshelton it looks like it is one of Albert Chakona's studies - not sure why data from Namibia is included?

Screenshot_2019-12-19 FBIS Map

helendallas commented 4 years ago

Add Site - generate Site Code not working correctly. I added a fictitious site, and ask that the FBIS Site Code be generate . The River name was not included as per the standardised naming format:

G2DISA-00001 but it came back as G2-00001

Screenshot_2019-12-19 FBIS Location Site Form(1)

I think it is because the River Name is not being fetched. I tried it again with the Berg River, and no name was fetched

And then it returns an Invalid Site Code Format Screenshot_2019-12-19 FBIS Location Site Form(2)

Then changed name so it was correct, and added photo, but got following error: Screenshot_2019-12-19 500 - Server Error

helendallas commented 4 years ago

Abiotic CSV download - Location Site strange

image

helendallas commented 4 years ago

Screenshot_2019-12-19 FBIS Single Site Dashboard - SASS

The SASS Taxa should be the same as the list in the SASS Form - not this one image

helendallas commented 4 years ago

Tried to add new SASS data to an existing Site but stumbled when said Add. Not working please check.

Screenshot_2019-12-19 500 - Server Error(1)

dimasciput commented 4 years ago

@jeremyshelton Metadata updated for gbif : image

http://freshwaterbiodiversity.org/map/#site-detail/taxon=&search=&siteId=&collector=&category=&yearFrom=&yearTo=&months=&boundary=&userBoundary=&referenceCategory=&spatialFilter=&reference=&endemic=&conservationStatus=%5B%5D&modules=1&validated=%5B%22validated%22%5D&sourceCollection=%5B%22gbif%22%5D&abioticData=&ecologicalCategory=&rank=&siteIdOpen=&orderBy=name

dimasciput commented 4 years ago

Spatial filters have been added back

image
dimasciput commented 4 years ago

For example, the fish dashboard for Galaxias zebratus failed to load for me multiple times: http://freshwaterbiodiversity.org/map/#site-detail/taxon=&search=Galaxias%20zebratus&siteId=&collector=&category=&yearFrom=&yearTo=&months=&boundary=&userBoundary=&referenceCategory=&spatialFilter=&reference=&endemic=&conservationStatus=[]&modules=1&validated=["validated"]&sourceCollection=["fbis"]&abioticData=&ecologicalCategory=&rank=&siteIdOpen=&orderBy=name

Fixed it

dimasciput commented 4 years ago

We changed ‘Spatial scale’ to ‘Spatial’ and ’Temporal scale’ to ’Temporal’ etc in the testing site, but these seem to have reverted back to their previous labels in the live site?

Fixed

image

dimasciput commented 4 years ago

Add Site - generate Site Code not working correctly. I added a fictitious site, and ask that the FBIS Site Code be generate . The River name was not included as per the standardised naming format:

@helendallas can you try it again? And please don't upload picture with large size, shouldn't be more than 5mb.

jeremyshelton commented 4 years ago

@jeremyshelton Metadata updated for gbif : image

http://freshwaterbiodiversity.org/map/#site-detail/taxon=&search=&siteId=&collector=&category=&yearFrom=&yearTo=&months=&boundary=&userBoundary=&referenceCategory=&spatialFilter=&reference=&endemic=&conservationStatus=%5B%5D&modules=1&validated=%5B%22validated%22%5D&sourceCollection=%5B%22gbif%22%5D&abioticData=&ecologicalCategory=&rank=&siteIdOpen=&orderBy=name

Thanks @dimasciput - looking good 👍

jeremyshelton commented 4 years ago

Spatial filters have been added back

image

👍

jeremyshelton commented 4 years ago

We changed ‘Spatial scale’ to ‘Spatial’ and ’Temporal scale’ to ’Temporal’ etc in the testing site, but these seem to have reverted back to their previous labels in the live site?

Fixed

image

👍

jeremyshelton commented 4 years ago

For example, the fish dashboard for Galaxias zebratus failed to load for me multiple times: http://freshwaterbiodiversity.org/map/#site-detail/taxon=&search=Galaxias%20zebratus&siteId=&collector=&category=&yearFrom=&yearTo=&months=&boundary=&userBoundary=&referenceCategory=&spatialFilter=&reference=&endemic=&conservationStatus=[]&modules=1&validated=["validated"]&sourceCollection=["fbis"]&abioticData=&ecologicalCategory=&rank=&siteIdOpen=&orderBy=name

Fixed it

@dimasciput OK cool - looks good. Did notice a bug on that dashboard: All Galaxias are native. Red bar should be Non-native, and should show a zero value here.

Screenshot 2019-12-21 at 07 55 46
dimasciput commented 4 years ago

For example, the fish dashboard for Galaxias zebratus failed to load for me multiple times: http://freshwaterbiodiversity.org/map/#site-detail/taxon=&search=Galaxias%20zebratus&siteId=&collector=&category=&yearFrom=&yearTo=&months=&boundary=&userBoundary=&referenceCategory=&spatialFilter=&reference=&endemic=&conservationStatus=[]&modules=1&validated=["validated"]&sourceCollection=["fbis"]&abioticData=&ecologicalCategory=&rank=&siteIdOpen=&orderBy=name

Fixed it

@dimasciput OK cool - looks good. Did notice a bug on that dashboard: All Galaxias are native. Red bar should be Non-native, and should show a zero value here.

Screenshot 2019-12-21 at 07 55 46

@jeremyshelton fixed it

jeremyshelton commented 4 years ago

For example, the fish dashboard for Galaxias zebratus failed to load for me multiple times: http://freshwaterbiodiversity.org/map/#site-detail/taxon=&search=Galaxias%20zebratus&siteId=&collector=&category=&yearFrom=&yearTo=&months=&boundary=&userBoundary=&referenceCategory=&spatialFilter=&reference=&endemic=&conservationStatus=[]&modules=1&validated=["validated"]&sourceCollection=["fbis"]&abioticData=&ecologicalCategory=&rank=&siteIdOpen=&orderBy=name

Fixed it

@dimasciput OK cool - looks good. Did notice a bug on that dashboard: All Galaxias are native. Red bar should be Non-native, and should show a zero value here.

Screenshot 2019-12-21 at 07 55 46

@jeremyshelton fixed it

Looks good now - thanks @dimasciput

jeremyshelton commented 4 years ago

When validated and non-validated are selected - there are some fish records from Namibia included. @jeremyshelton it looks like it is one of Albert Chakona's studies - not sure why data from Namibia is included?

Screenshot_2019-12-19 FBIS Map

@Aneri16 Can you please track down the data points (1) in Namibia and (2) in the ocean and either correct the coords or remove these from our fish data set? Thanks

jeremyshelton commented 4 years ago

Abiotic CSV download - Location Site strange

image

@helendallas if possible please include url's for these issues in the future- makes following up much easier. Thanks

aneriswanepoel commented 4 years ago

@jeremyshelton will do. Seems to be four data points outside of SA, and in the ocean too.

jeremyshelton commented 4 years ago

@jeremyshelton will do. Seems to be four data points outside of SA, and in the ocean too.

Yes, rather odd 🤔 Please investigate and see if it is our error, or the author's error (in which case we should probably remove those records...)

jeremyshelton commented 4 years ago

FISH METADATA @dimasciput in some cases there seem to be no metadata associated with a record, and Toni is the owner in the csv - the owner should be the study author, right?

aneriswanepoel commented 4 years ago

@jeremyshelton @dimasciput I have corrected and or deleted the sites that were not in SA or were in the ocean. Should be all of them. Dimas might have to refresh on his side for the dots to disappear from the map.

jeremyshelton commented 4 years ago

@jeremyshelton @dimasciput I have corrected and or deleted the sites that were not in SA or were in the ocean. Should be all of them. Dimas might have to refresh on his side for the dots to disappear from the map.

Thanks @Aneri16. @dimasciput looks like its sorted now:

Screenshot 2020-01-10 at 13 58 56