kartoza / django-bims

https://testing.healthyrivers.kartoza.com
GNU Affero General Public License v3.0
12 stars 19 forks source link

Pesticide Risk Maps #3319

Closed helendallas closed 1 year ago

helendallas commented 1 year ago

Thanks Amy. These look good. Some comments.

**1. Please make No Application white not transparent.

2. Abstracts are missing.** Here is the general one James provided previously - I suggest revising for each group - fish, invertebrates or algae

so it would read as follows for the start of each map

Maps provide an indication of the relative risk of combined pesticide use to fish at a quaternary catchment scale. ETC for invertebrates and algae. Then from second sentence same for all. Shout if unclear.

Maps provide an indication of the relative risk of combined pesticide use to aquatic biota (fish, invertebrates and algae) at a quaternary catchment scale. Attribute data lists risk factors per pesticide and can be used to identify and prioritise those pesticides that contribute the greatest proportion of the total risk to aquatic organisms. [Source: Dabrowski, J.M. (2022). An Integrated Approach to Managing and Mitigating the Risk of Agricultural Nonpoint Source Pesticide Pollution to the Aquatic Environment. Volume 2: Development of Risk Maps and a Risk Indicator for Identifying Hotspots and Prioritising Risks of Pesticide use to Aquatic Ecosystem Health. WRC Report No. TT 885/22. Water Research Commission, Pretoria.

**3. Add option to download the attribute data when a user clicks on a particular catchment.** For example on the Hydrological Region Flow Type, when I click on a polygon, the attribute data comes up as well as an option to download the data. Will it be possible to include this for the risk maps? image

see download data image

One issue is for the hydrological regions all data are downloaded, not just for the quaternary. See ticket #2838

@dimasciput was going to spend time on this, but we parked it. If it is coming up for pesticides as well then please use the pesticide budget to fix all pesticide risk maps so a user can download the csv file for a selected quaternary catchment, and then carry over the fix for the hydrological regions.

amyburness commented 1 year ago

@helendallas making updates now.

  1. White done image
  2. Abstracts added and updated image
  3. @dimasciput, how do I add the download button?
helendallas commented 1 year ago

Thanks @amyburness

Sorry but white looks a bit strange as disappears in legend, Can you please make a gray??? Thanks

image

amyburness commented 1 year ago

Sure they are grey now.

On Wed, 15 Feb 2023 at 07:33, Helen Dallas @.***> wrote:

Thanks @amyburness https://github.com/amyburness

Sorry but white looks a bit strange as disappears in legend, Can you please make a gray??? Thanks

[image: image] https://user-images.githubusercontent.com/45286876/218941438-6ff8eecb-f702-408b-b622-e4587fd5ee8c.png

— Reply to this email directly, view it on GitHub https://github.com/kartoza/django-bims/issues/3319#issuecomment-1430781012, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASR4I2QMRRX46FSFET7XZATWXRTEFANCNFSM6AAAAAAU3O5TZM . You are receiving this because you were mentioned.Message ID: @.***>

--

Amy Burness Junior GIS Specialist / technician Visit http://kartoza.com to find out about open source:

helendallas commented 1 year ago

Thanks @amyburness

Please can you fix text so that No application is not cut off - for fish, inverts and algae

image

Also this needs Dimas's input please

  1. Add option to download the attribute data when a user clicks on a particular catchment. For example on the Hydrological Region Flow Type, when I click on a polygon, the attribute data comes up as well as an option to download the data. Will it be possible to include this for the risk maps? image

see download data image

One issue is for the hydrological regions all data are downloaded, not just for the quaternary. See ticket https://github.com/kartoza/django-bims/issues/2838

@dimasciput was going to spend time on this, but we parked it. If it is coming up for pesticides as well then please use the pesticide budget to fix all pesticide risk maps so a user can download the csv file for a selected quaternary catchment, and then carry over the fix for the hydrological regions.

dimasciput commented 1 year ago

@helendallas @jeremyshelton

  1. Add option to download the attribute data when a user clicks on a particular catchment. For example on the Hydrological Region Flow Type, when I click on a polygon, the attribute data comes up as well as an option to download the data. Will it be possible to include this for the risk maps? @dimasciput was going to spend time on this, but we parked it. If it is coming up for pesticides as well then please use the pesticide budget to fix all pesticide risk maps so a user can download the csv file for a selected quaternary catchment, and then carry over the fix for the hydrological regions.

I will work on this today and should be done by the end of the day.

dimasciput commented 1 year ago

image

I have deployed to testing.

helendallas commented 1 year ago

Thanks. For pesticides is it possible for the download to resemble what is seem on the tab, fid Quaternary Toxic Unit Score Risk Category Abamectin, etc.

image

helendallas commented 1 year ago

Same with Hydrological Region Flow Type, some info missing in csv, should be same as what is in the tab

image

helendallas commented 1 year ago

@dimasciput Neither testing or production have the download option anymore????

image

image

dimasciput commented 1 year ago

@helendallas, the issues with the risk layer have all been resolved in production. As for the Hydrological Region Flow Type, I will address it in a separate ticket later.

amyburness commented 1 year ago

@helendallas I have the csv's for this I just have a question before @dimasciput correct the data. for this data, three is a full data set and a summarised materialized view we made for viewing on the map because having the 100+ attributes didn't make sense. when the user downloads the data must it be the full data set?

helendallas commented 1 year ago

Thanks @dimasciput Looks good now.

There is already a ticket for the hydrological regions, see #https://github.com/kartoza/django-bims/issues/2838

I will close this ticket now