kartoza / django-bims

https://testing.healthyrivers.kartoza.com
GNU Affero General Public License v3.0
12 stars 19 forks source link

Invasions missing from CSV download in Taxon Management #4273

Closed helendallas closed 1 month ago

helendallas commented 2 months ago

Invasion categories were added to SANParks - see e.g. Birds success upload file.

But when we download the CSV from the Bird Module in Taxa Management, no Invasions column is downloaded.

Screenshot 2024-10-01 at 10 11 52

See example here with no Invasions column in the csv.

Screenshot 2024-10-01 at 10 13 53
dimasciput commented 2 months ago

Hi @helendallas

The invasion value needs to be added to the origin column. So, it should be origin => Category 2a invasive, and it will automatically add the species as non-native.

So, this is not a bug, but I can add this feature. It will take 2-3 hours, but I'm not sure if this is part of the sanpark requirements.

dimasciput commented 2 months ago

@helendallas https://github.com/kartoza/django-bims/issues/3984#issuecomment-2296402785

helendallas commented 2 months ago

Ah okay. Let me discuss with SANParks. I also misunderstood. I will revert

helendallas commented 2 months ago

@dimasciput I did not understand the workflow here. Can we have it working the same way as endemism please.

Origin - native - then fill in endemism field for endemism category

Origin - non-native - then fill in invasion field for invasion category

The Origin field should only be used to indicate if the origin of the species is SA (native) or not SA (non-native), not endemism or invasion status

dimasciput commented 1 month ago

@helendallas I have added this functionality, so please try to upload it again.

helendallas commented 1 month ago

@dimasciput I don't think I get what you have done here.

The team uploaded the invasions as a separate column for reptiles, but it is still not coming down in csv.

reptiles_invasion testing upload_04-10.csv

success_reptiles_invasion_testing_04-10.csv

Reptiles-2024-10-4_master list download after testing.csv

dimasciput commented 1 month ago

@helendallas ah I haven't updated the master list download. Let me fix it quickly.

helendallas commented 1 month ago

@dimasciput Please confirm when this is done.

dimasciput commented 1 month ago

@helendallas this has been added to production and staging

helendallas commented 1 month ago

Not seeing it in download?

helendallas commented 1 month ago
Screenshot 2024-10-07 at 09 49 29

Ok I am but please put it with the other attributes etc. not in taxonomy - after endemism

helendallas commented 1 month ago

Checked and now in Production csv download, closing ticket