kartoza / docker-pg-backup

A cron job that will back up databases running in a docker postgres container
GNU General Public License v2.0
452 stars 103 forks source link

Backport from 9.6 #12

Closed lucernae closed 5 years ago

lucernae commented 5 years ago

Add ARCHIVE_FILENAME parameters to specify fixed filename (#11)

lucernae commented 5 years ago

@NyakudyaA @timlinux Do you have any comment on this?

NyakudyaA commented 5 years ago

@lucernae The backup script does not backup globals (users and permissions). We should include it pg_dumpall -h localhost -p 5432 -U docker -v --globals-only -f "/path/to/globals.sql"

This is quite important as the starting point for any restore should always be

lucernae commented 5 years ago

@NyakudyaA I see. There are some parts that needs to be changed.

@lucernae we are trying to do away with the template method for installing PostGIS see kartoza/docker-postgis#119

Yes! it will help the restore process if we can get what extensions to include.

@lucernae The backup script does not backup globals (users and permissions). We should include it pg_dumpall -h localhost -p 5432 -U docker -v --globals-only -f "/path/to/globals.sql"

We might have to change the backup script for this.

Can I request that both changes be done in a separate issue/PR after this, since those changes is specific for the latest kartoza/postgis base images.

I'm trying to keep this PR for backport changes only from 9.6 to master. Which includes:

Do we have any more feedback for those points?

NyakudyaA commented 5 years ago

@lucernae LGTM we can open another issue for those things I mentioned