Incorrect env variables names

[androane]

pgenv.sh has

export PGUSER=docker
export PGPASSWORD=docker
export PGPORT=5432
export PGHOST=db
export PGDATABASE=gis
export DUMPPREFIX=PG
export ARCHIVE_FILENAME=

while the documentation has other variable names

[NyakudyaA]

@androane look at start.sh you will see the environment variables being used there

[androane]

@NyakudyaA yes. What I'm trying to say is that there's a mismatch between those names and the ones in the doc (ex PGUSER vs POSTGRES_USER)

[NyakudyaA]

@androane I do not see them perhaps you can point me on the correct line where there is a mismatch. The best way for you would be to fix the issues and we can look at your PR and happily merge

[androane]

Depending on what you want to change. The docs or the basecode :)

Readme: https://github.com/kartoza/docker-pg-backup#specifying-environment In start.sh: https://github.com/kartoza/docker-pg-backup/blob/master/start.sh#L42

Note that the ones in start.sh are like PGUSER. In the README, there's POSTGRES_USER, which is not being used at all in start.sh.

[NyakudyaA]

@androane You can change the script start.sh to match the environment variables in the doc. Thanks for picking it up

[androane]

@NyakudyaA why not the other way around?

[NyakudyaA]

@androane Because this image inherits from the kartoza/postgis:version so anything changed should apply directly to upstream images

[androane]

@NyakudyaA can't push branch because of permissions. Would like to open a PR

[NyakudyaA]

@androane just do a fork of this repo, do your work and then do a PR against this branch and I will review it and merge

[androane]

@NyakudyaA would like to create a PR, but can't push my local branch

[NyakudyaA]

@androane give me the URL of your branch

[androane]

@NyakudyaA are we talking different languages? I cloned the repo. I created a local new branch. I did the changes. Now I'm trying to push the branch to your repo so I can open a PR. But I don't have permission. So what URL do you want ??

[NyakudyaA]

@androane That is not how you should be doing it.

• Fork this repository so that it exists in your own credentials

• Clone your local copy of the repository ie git clone https://github.com/NyakudyaA/docker-pg-backup.git

• Create a branch in your local environment

• Push your changes into your local branch

• Create a pull request using the UI in github

[androane]

Done

[NyakudyaA]

thanks @androane I will take a look and test

[androane]

@NyakudyaA will this be done soon? I need it and I was wondering if I should use my fork or wait for your update. Thanks!

[NyakudyaA]

Hi @androane I will merge soon and push a new image

[androane]

@NyakudyaA when I pull your image from dockerhub, it's still not working. Perhaps that image is not updated? It's looking at all PG prefixes env variables, instead of POSTGRES_. Haven't tried yet, but most probably it works if I ony clone the repo due to the latest fix

[NyakudyaA]

@androane You can clone the repo and build it , I am still waiting for permission to push to that specific repo in docker hub

[androane]

any news on updating the image in dockerhub? I'd really need it :)

[NyakudyaA]

Done in dockerhub