kartoza / geonode

GeoNode is an open source platform that facilitates the creation, sharing, and collaborative use of geospatial data.
http://geonode.org/
GNU General Public License v3.0
8 stars 17 forks source link

Use 'Data' tab properly #348

Closed gubuntu closed 7 years ago

gubuntu commented 7 years ago

Issue

Why is there a 'Data' link in the layer download section? That you have to click on to get the list of download links...

Solution

Remove the tree and show all download links immediately, as in the GeoServer GeoNode

boney-bun commented 7 years ago

looking at the code, there should be two tabs, namely download_tab1 for viewing and download_tab2 for downloading. i never see the two tabs appear together. however, maybe it's there because of a reason. i just not sure the business logic for this.

perhaps @Gustry could make a comment as it relates to Links?

Gustry commented 7 years ago

Looking at a Geoserver instance, two tabs are there: http://staginggs.geonode.kartoza.com/layers/geonode:tmpwllgcy

It's not us who created this "data" item. Maybe we should organize better our links between these 2 tabs.

gubuntu commented 7 years ago

I was referring to the download dialog on demo.geonode.org (which I see is still 2.4). So maybe the tabs appeared in 2.6?

Anyway, if they are there and we have to use them I agree with Etienne that we should put our links in the appropriate tab but also auto expand them so the user does not have to guess and click again before seeing download options.

screen shot 2017-09-28 at 09 28 00
gubuntu commented 7 years ago

OK this is the latest Tab structure (from http://staginggs.geonode.kartoza.com)

So our Data Tab should list all links automatically and not have to be clicked on to expand the list.

screen shot 2017-09-28 at 09 41 48
Gustry commented 7 years ago

@boney-bun We should check what we made wrong in qgis-server backend, why it 's not open by default. I don't think we need to change the geonode code base.

boney-bun commented 7 years ago

agree @Gustry i found that the code expect the viewing tab (first tab) to be exist and make the list available by default.

351 should fix the problem.

gubuntu commented 7 years ago

@boney-bun is this deployed on the testing server and did you test it there?

btw the testing server is down

boney-bun commented 7 years ago

@gubuntu sorry, i forgot to reopen it. it was part of my experiment because the testing wasn't updated using the latest repo. i have reopened it.

gubuntu commented 7 years ago

passed on testing