search

kartoza / geonode

GeoNode is an open source platform that facilitates the creation, sharing, and collaborative use of geospatial data.
http://geonode.org/
GNU General Public License v3.0
8 stars 17 forks source link

fix thumbnail reset when new default style is set #473

Closed boney-bun closed 5 years ago

boney-bun commented 6 years ago

fix #426

boney-bun commented 6 years ago

the PR in action: changedefaultstyle

codecov[bot] commented 6 years ago

Codecov Report

Merging #473 into 2.8.x-qgis_server will increase coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           2.8.x-qgis_server     #473      +/-   ##
=====================================================
+ Coverage              40.92%   40.98%   +0.05%     
=====================================================
  Files                    410      410              
  Lines                  29330    29335       +5     
  Branches                3723     3723              
=====================================================
+ Hits                   12003    12022      +19     
+ Misses                 16581    16564      -17     
- Partials                 746      749       +3
Impacted Files Coverage Δ
geonode/qgis_server/views.py 60.41% <100%> (+3.19%) :arrow_up:
geonode/qgis_server/tests/test_views.py 99.73% <100%> (ø) :arrow_up:
geonode/qgis_server/helpers.py 66.84% <0%> (+0.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4e9c28...a165514. Read the comment docs.

gubuntu commented 5 years ago

fix so you can merge asap @boney-bun

boney-bun commented 5 years ago

thanks for the feedback @lucernae this PR intends to fix a bug when setting a new default style. the PR handles the non 4326 SRS.

i'm going to merge this PR and bring it to testing.