Closed boney-bun closed 5 years ago
@lucernae the unittest will come later as i'm still struggling to make it passed
Merging #474 into 2.8.x-qgis_server will increase coverage by
0.01%
. The diff coverage is76.92%
.
@@ Coverage Diff @@
## 2.8.x-qgis_server #474 +/- ##
=====================================================
+ Coverage 41.36% 41.37% +0.01%
=====================================================
Files 403 403
Lines 28950 28968 +18
Branches 3671 3678 +7
=====================================================
+ Hits 11974 11986 +12
- Misses 16234 16236 +2
- Partials 742 746 +4
Impacted Files | Coverage Δ | |
---|---|---|
geonode/qgis_server/signals.py | 83.26% <71.42%> (-0.69%) |
:arrow_down: |
geonode/qgis_server/helpers.py | 66.31% <83.33%> (-0.18%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2c153ec...28aeb94. Read the comment docs.
merge and deploy asap @boney-bun so we can test
thanks @lucernae i'm going to merge this
the end result will be similar to the abandon #472
fix #406 fix #325