kartoza / geonode

GeoNode is an open source platform that facilitates the creation, sharing, and collaborative use of geospatial data.
http://geonode.org/
GNU General Public License v3.0
8 stars 17 forks source link

removes space and a few other characters from the file name in download section #478

Closed boney-bun closed 5 years ago

boney-bun commented 6 years ago

fix #360

codecov[bot] commented 6 years ago

Codecov Report

Merging #478 into 2.8.x-qgis_server will increase coverage by 2.87%. The diff coverage is 83.33%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           2.8.x-qgis_server     #478      +/-   ##
=====================================================
+ Coverage              38.66%   41.54%   +2.87%     
=====================================================
  Files                    403      403              
  Lines                  28878    28882       +4     
  Branches                3667     3667              
=====================================================
+ Hits                   11167    11998     +831     
+ Misses                 16966    16140     -826     
+ Partials                 745      744       -1
Impacted Files Coverage Δ
geonode/maps/qgis_server_views.py 64.42% <100%> (+0.22%) :arrow_up:
geonode/qgis_server/views.py 57.78% <75%> (+0.33%) :arrow_up:
geonode/services/views.py 22.54% <0%> (ø) :arrow_up:
geonode/security/utils.py 34.3% <0%> (ø) :arrow_up:
geonode/qgis_server/helpers.py 68.9% <0%> (+0.53%) :arrow_up:
geonode/api/api.py 63.74% <0%> (+0.72%) :arrow_up:
geonode/qgis_server/models.py 81.95% <0%> (+0.75%) :arrow_up:
geonode/qgis_server/signals.py 86.19% <0%> (+0.83%) :arrow_up:
geonode/api/resourcebase_api.py 43.95% <0%> (+0.87%) :arrow_up:
geonode/geoserver/signals.py 15.48% <0%> (+0.88%) :arrow_up:
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 73f2e8e...1437116. Read the comment docs.

gubuntu commented 5 years ago

fix and merge asap @boney-bun

boney-bun commented 5 years ago

@lucernae is there a way to bypass travis in order to merge PRs? i can't merge this PR (and a few others) since the travis failed on geoserver backend. the error does not related to the code, but the connection is terminated from the travis.

lucernae commented 5 years ago

We will merge this despite travis error due to #501