access_token query string on resource.get_legend.url causes legend image to not appear

kartoza / geonode_qgis_server

Django app to make geonode work with QGIS Server

MIT License

9 stars 6 forks source link

access_token query string on resource.get_legend.url causes legend image to not appear #11

Closed senoadiw closed 7 years ago

senoadiw commented 7 years ago

geonode_qgis_server version: 0.1.1
GeoNode version: 2.5.10
Python version:
Operating System:

Description

On recent GeoNode versions, for logged in users the access_token query string is appended to the resource.get_legend.url in https://github.com/GeoNode/geonode/blob/47f2a42ff60be0c0c427b78df5e73a411ac2b2e1/geonode/layers/templates/layers/layer_detail.html#L430

For anonymous users the legend appears fine. Here is what it looks like as admin user:

docker-geonode-qgis legend

Thanks

ismailsunni commented 7 years ago

Thanks @senoadiw for the report. Well, I haven't tested with the current version of geonode. It seems, they added new code that geoserver-specific. But it doesn't cover QGIS Server, unfortunatelly.

timlinux commented 7 years ago

@ismailsunni we should write a regex to strip off the access token before passing the request downstream to QGIS server?

ismailsunni commented 7 years ago

Hmm, after looked at the code again, the access token should be ignored since it's a GET parameter and the legend should have been shown.

@timlinux yes, that can work

gubuntu commented 7 years ago

This issue was moved to kartoza/geonode#189

gubuntu commented 7 years ago

This issue was moved to kartoza/geonode#190