Refactor django.conf.settings access

kartoza / geonode_qgis_server

Django app to make geonode work with QGIS Server

MIT License

9 stars 6 forks source link

Closed lucernae closed 8 years ago

lucernae commented 8 years ago

Properly access django settings. Useful for modularity.

lucernae commented 8 years ago

please review @ismailsunni

ismailsunni commented 8 years ago

LGTM

senoadiw commented 7 years ago

Hello, it looks like the package @ https://pypi.python.org/pypi/geonode_qgis_server needs updating since it still calls from geonode.settings import QGIS_SERVER_CONFIG

This causes geonode_qgis_server to break GeoNode that uses a custom settings file like my_geonode.settings.

Cheers

timlinux commented 7 years ago

Hi @senoadiw

Maybe it is better to file a fresh ticket as I fear your comment will get buried here in the comments of a closed pull request.

@ismailsunni can you investigate the query above?