search

kartoza / geosafe

InaSAFE package for Geonode
GNU General Public License v3.0
7 stars 16 forks source link

can't start new analysis without resetting #482

Open gubuntu opened 5 years ago

gubuntu commented 5 years ago

I viewed Tim's analysis (156) then wanted to start a new one. So I chose a new hazard and exposure layer but when I got to choosing an aggregation layer it would not draw.

either this is a bug or the user must be advised to reset to begin a new analysis Screenshot 2018-11-15 at 09.32.20.png

gubuntu commented 5 years ago

mmm, now it's working

gubuntu commented 5 years ago

it drew, but the Run button is not active. I had to reset and start again.

Why is is not possible to start a new analysis without resetting?

myarjunar commented 5 years ago

@lucernae I see in the js logic of this part that it will not allow run button to enable if its an analysis page. any reason for this? we could easily remove that logic anyway

lucernae commented 5 years ago

In some sense (REST perspective), if you click a detail URL, you are supposed to be only viewing that resource. Because an Analysis are supposed to be uneditable. The thing that is misleading is we don't have any proper UI guideline on how to present a detail URL of Analysis. Let's suppose, when viewing an analysis detail we hide all action button (the run button) and only shows the layer that these analysis ran (we hide all hazard/exposure/aggregation that is not part of the analysis), then the user will understand that this is just a view page, not an Analysis Creation page. To create analysis, you go to Analysis Creation Page (the URL is different). In this case, by clicking the reset button (or somehow change that button to represent, Create A New Analysis). But this entirely depends on bussiness logic that the client prefer. As @myarjunar we could easily remote that logic as you prefer. As long as the User understand that when doing this, it will create a new anlysis, not updating the previous one. Unless updating an analysis is the logic. It's just depends on what the user will think about it conceptually. We will just follow accordingly.

gubuntu commented 5 years ago

doesn't sound like something we should be tackling in a hurry, moved to backlog