kartoza / least-cost-electrification-somalia

Global Electrification Platform for Global
1 stars 0 forks source link

Need more descriptions on popup regarding investments and capacity values. #48

Closed lucernae closed 2 years ago

lucernae commented 2 years ago

From the discussion in 18 Nov with the client, they are a little bit confused about what the values means in the popup and why it seems to be not consistent with the summary sidebar.

Screenshots below for demo:

image

Problem is: investments only shows around 54 million, but total in summary shows 376 million.

@meomancer has indicated that the count itself in the summary panel is correct because it is counting based on the left panel filters. In this particular example, the remaining "missing" investments comes from the time range from 2025 to 2030. However the popup only shows investments data of timeslice between 2025 to 2030, meanwhile the total summary includes data from before 2025 and up to 2030. If we change the timeslice to 2025, we can see that the popup shows investments around 300 million.

@meomancer suggests that we can improve the popup clarity by doing these:

Since this is development issue, I will let developer handle it and ping me when it needs redeployment.

CC @lkwalke4 @timlinux @meomancer

meomancer commented 2 years ago

hi @lucernae PR is here: https://github.com/kartoza/least-cost-electrification-somalia/pull/50

we need to merge and deploy frontend : https://github.com/kartoza/global-electrification-platform-explorer/pull/10 and backend : https://github.com/kartoza/global-electrification-platform-data-service/pull/1https://github.com/kartoza/global-electrification-platform-data-service/pull/1

I found that: on summary, Investement Cost is total from today to the selected year (2025 + 2030) but on added capacity, they are not in total

So the PR of backend is change the added capacity to also in total

lucernae commented 2 years ago

Hi @meomancer I don't think I have enough knowledge to review. Can you go ahead and merge (both in submodules and this repo), then instruct me how to deploy the changes? I assume since both are submodules, I have to git submodule update and rebuilt the entire containers? CMIIW.

meomancer commented 2 years ago

hi @lucernae i already deployed that please check it (and do hard refresh) Selection_310

lucernae commented 2 years ago

Thanks @meomancer , Can you just confirm my question here:

Hi @meomancer I don't think I have enough knowledge to review. Can you go ahead and merge (both in submodules and this repo), then instruct me how to deploy the changes? I assume since both are submodules, I have to git submodule update and rebuilt the entire containers? CMIIW.

This information is needed for internal deployment procedure document for our DevOps, since this stack does not use k8s.

Please provide any missing steps/procedure so I can document it.

meomancer commented 2 years ago

Hi @lucernae Yes, just update the submodule After that restart backend, frontend and ngix container in order

lucernae commented 2 years ago

Done, documented in the kartoza/devops as well.