kartoza / least-cost-electrification-somalia

Global Electrification Platform for Global
1 stars 0 forks source link

MapBox BaseMap Does Not Match The Country Boundary Layer Uploaded #51

Closed seabilwe closed 2 years ago

seabilwe commented 2 years ago

Hi @lkwalke4 @timlinux cc @lucernae @meomancer

I have been correcting the country boundary that was said it did not match the base map in the SEP and the Geonode basemaps in this ticket #47. I managed to get it to match the boundaries of the OSM basemaps image image

Now the issue is the mapbox basemap, when placing the country boundary layer on the SEP, the outlines do not match. For example: image

But also the mapbox's boundaries alone are not aligned properly: image

Please note that @lucernae has mentioned this on the #47 image image

meomancer commented 2 years ago

i think we can change basemap from mapbox to osm?

lucernae commented 2 years ago

@meomancer how do we add this basemap just like in somaliland https://somalielectrification.so/geoserver/web/wicket/bookmarkable/org.geoserver.web.data.layergroup.LayerGroupPage?21

I see that in somaliland it was added not as a basemap but a default-active layer. You can just point me to the relevant files and I can try to deploy it on SEAP before we make a commit.

lucernae commented 2 years ago

Wait a minute, I think I can just change it in externalLayers.json if it is indeed considered as one, CMIIW @meomancer

lucernae commented 2 years ago

I was able to do a quick patch and see the result here:

image

The mapbox boundaries are still slightly visible. To see the basemap, enable "Somalia Basemap" from the layer selection.

Perhaps we have to make the basemap more opaque-white or less-transparent to override that wrong boundaries from mapbox? How about it @seabilwe ?

seabilwe commented 2 years ago

Okay, I'll remove the transparency that I added to the 'Somalia Basemap' @lucernae

seabilwe commented 2 years ago

ive removed the opacity @lucernae

lucernae commented 2 years ago

I think this is nice. I will set it as the default basemap for now and ask the client for confirmation. If they are okay with it, we can proceed with the PR.

image
lucernae commented 2 years ago

Done and deployed as the default basemap.