search

kartoza / prj.app

A django app for creating visual changelogs for software releases
29 stars 32 forks source link

Validate the uploaded zipfile #1314

Closed sumandari closed 3 years ago

sumandari commented 3 years ago

This PR refers to #1252. It provides validation during uploading the zipfile.

image

codecov[bot] commented 3 years ago

Codecov Report

Merging #1314 (9d65644) into develop (58aec98) will increase coverage by 0.11%. The diff coverage is 97.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1314      +/-   ##
===========================================
+ Coverage    64.19%   64.31%   +0.11%     
===========================================
  Files          180      180              
  Lines         9629     9664      +35     
  Branches       751      758       +7     
===========================================
+ Hits          6181     6215      +34     
  Misses        3204     3204              
- Partials       244      245       +1
Impacted Files Coverage Δ
django_project/lesson/utilities.py 82.50% <96.66%> (+8.50%) :arrow_up:
django_project/lesson/forms/worksheet.py 82.05% <100.00%> (+2.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 58aec98...9d65644. Read the comment docs.

sumandari commented 3 years ago

@dimasciput I updated with ignore list. Would please kindly re-review it. Thank you

dimasciput commented 3 years ago

LGTM!