kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

Create tool to generate invalid FurtherReading link (in progress) #1327

Closed sumandari closed 3 years ago

sumandari commented 3 years ago

This PR fixes #1326.

/cc @NyakudyaA

codecov[bot] commented 3 years ago

Codecov Report

Merging #1327 (e7e8fcf) into develop (f243a60) will decrease coverage by 0.00%. The diff coverage is 62.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1327      +/-   ##
===========================================
- Coverage    63.82%   63.82%   -0.01%     
===========================================
  Files          180      180              
  Lines         9541     9618      +77     
  Branches       736      748      +12     
===========================================
+ Hits          6090     6139      +49     
- Misses        3218     3242      +24     
- Partials       233      237       +4     
Impacted Files Coverage Δ
django_project/lesson/urls.py 86.66% <ø> (ø)
django_project/lesson/views/further_reading.py 52.30% <23.07%> (-19.49%) :arrow_down:
django_project/lesson/utilities.py 71.42% <82.35%> (+21.42%) :arrow_up:
django_project/lesson/signals/further_reading.py 100.00% <0.00%> (+14.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f243a60...e7e8fcf. Read the comment docs.

sumandari commented 3 years ago

click on the check invalid link button

image

checking the invalid link

image


result with anchor element

image


changelog_1326

NyakudyaA commented 3 years ago

Thanks, @sumandari, Can you save that output to PDF or any format.

sumandari commented 3 years ago

Alright @NyakudyaA, I will create the function to save the output.

sumandari commented 3 years ago

Add the download button in modal:

invalid_further_link


PDF result

invalid_further_link_pdf

NyakudyaA commented 3 years ago

Can we get this merged @sumandari

sumandari commented 3 years ago

some changes haven't covered by unit test. will added it with another ticket.