search

kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

Simplify sample data export formats #1328

Closed NyakudyaA closed 3 years ago

NyakudyaA commented 3 years ago

Problem

Currently, if a user downloads sample data from a worksheet i.e sample-data-work

And then unzip the file produces a file structure that is two folders deep. ie.

It seems like after uploading the sample data as a zip file, it is further zipped again.

Solution

If we need to standardize the name of the zip file let us rather rename a zip file that is uploaded rather than zip a zip file. What is the benefit of zipping twice?

sumandari commented 3 years ago

@NyakudyaA is this duplicate with #1337 ?

NyakudyaA commented 3 years ago

Yes @sumandari in fact Tim's ticket is the duplicate as I wrote this earlier than him but we can close this 🙂🙂🙂

sumandari commented 3 years ago

@NyakudyaA I submitted #1341 It's unzipping file when author uploaded sample data with zip in zip. Please confirm if it's not necessary, I will close it then.

NyakudyaA commented 3 years ago

I will look at the PR and comment

sumandari commented 2 years ago

The fix has been released in v2.3.0 and deployed on prod.