search

kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

Elegant aspect ratios for youtube embeds #1331

Open zacharlie opened 3 years ago

zacharlie commented 3 years ago

Youtube video embeds have different aspect ratios and the lessons video frame is square, resulting in a lot of negative space surrounding the video.

image

A couple of resources describing the issue and possible fixes include:

Unfortunately these suggestions seem to assume that the video content will have the same dimensions, which is not necessarily the case and ideally this frame should dynamically adjust to suit the content.

If having to make it static, 16:9 (typical screen ratio) is probably best, but really, you would think that at this point an elegant solution exists for dynamic video content, so if you can find one please implement it. We definitely do not want to crop or distort any content either, so if we have to live with the negative space, so be it.

sumandari commented 3 years ago

I was following the steps on https://www.ankursheel.com/blog/full-width-you-tube-video-embed, modifying the CSS, but it didn't work as expected. On #1343 instead of changes the YouTube ratio, it changes the iframe ratio. I'm not sure if it's required.