kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

Fix the name encoding for sample data in lessons #1332

Closed sumandari closed 3 years ago

sumandari commented 3 years ago

This PR fixed #1329

Before:

image


After:

image

codecov[bot] commented 3 years ago

Codecov Report

Merging #1332 (94af904) into develop (f243a60) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1332      +/-   ##
===========================================
- Coverage    63.82%   63.82%   -0.01%     
===========================================
  Files          180      180              
  Lines         9541     9540       -1     
  Branches       736      736              
===========================================
- Hits          6090     6089       -1     
  Misses        3218     3218              
  Partials       233      233              
Impacted Files Coverage Δ
django_project/lesson/views/worksheet.py 73.81% <100.00%> (-0.10%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f243a60...94af904. Read the comment docs.

NyakudyaA commented 3 years ago

@sumandari an we get this merged as well