search

kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

GitHub PR parser : add more checks in the regexp #1335

Closed Gustry closed 3 years ago

Gustry commented 3 years ago

@sumandari It's ok to merge, covered by tests.

sumandari commented 3 years ago

Thank you @Gustry, could you please fix the test so that it gives the green tick?

Gustry commented 3 years ago

Done @sumandari

codecov[bot] commented 3 years ago

Codecov Report

Merging #1335 (43e61fc) into develop (ca2ee6e) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1335   +/-   ##
========================================
  Coverage    63.82%   63.83%           
========================================
  Files          180      180           
  Lines         9541     9542    +1     
  Branches       736      736           
========================================
+ Hits          6090     6091    +1     
  Misses        3218     3218           
  Partials       233      233
Impacted Files Coverage Δ
...jango_project/changes/utils/github_pull_request.py 92.00% <100.00%> (+0.33%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca2ee6e...43e61fc. Read the comment docs.

sumandari commented 3 years ago

Thank you @Gustry! I will merge it now.

linfiniti commented 3 years ago

Thanks Sumandari. Will you take a server snapshot then deploy it?

Sent from my iPhone

On 30 Apr 2021, at 04:14, sumandari @.***> wrote:

 Merged #1335 into develop.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

sumandari commented 3 years ago

Hi @linfiniti, this commit has been deployed on https://changelog.qgis.org. (version 2.1.3)