search

kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

added download button on worksheet detail #1338

Closed sumandari closed 3 years ago

sumandari commented 3 years ago

Please see #1337

image

codecov[bot] commented 3 years ago

Codecov Report

Merging #1338 (23d0e87) into develop (6b9237d) will decrease coverage by 0.06%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1338      +/-   ##
===========================================
- Coverage    63.82%   63.76%   -0.07%     
===========================================
  Files          180      180              
  Lines         9618     9628      +10     
  Branches       748      751       +3     
===========================================
  Hits          6139     6139              
- Misses        3242     3252      +10     
  Partials       237      237
Impacted Files Coverage Δ
django_project/lesson/views/worksheet.py 71.22% <0.00%> (-2.60%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b9237d...23d0e87. Read the comment docs.

zacharlie commented 3 years ago

Not sure if it matters whether the download data button should come before or after the PDF button. My thinking would be to move the download data button before the PDF button because not all lessons include sample data and it may remain a bit more consistent. maybe @timlinux can advise.

timlinux commented 3 years ago

Not sure if it matters whether the download data button should come before or after the PDF button. My thinking would be to move the download data button before the PDF button because not all lessons include sample data and it may remain a bit more consistent. maybe @timlinux can advise.

Yup that makes sense thanks - @sumandari will you do that? Will be great if you can get this deployed tomorrow @sumandari before training starts...

dimasciput commented 3 years ago

Hi @sumandari , can you use these icons for the download buttons download_icon.zip

sumandari commented 3 years ago

This fix has been deployed on changelog.kartoza.com and changelog.qgis.org version 2.1.5

timlinux commented 3 years ago

Thank you very much @sumandari !