kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

Update email setting #1340

Open sumandari opened 3 years ago

sumandari commented 3 years ago

Please see #1140

codecov[bot] commented 3 years ago

Codecov Report

Merging #1340 (4bf7c7e) into develop (08d62fb) will increase coverage by 0.00%. The diff coverage is 30.76%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1340   +/-   ##
========================================
  Coverage    63.76%   63.76%           
========================================
  Files          180      180           
  Lines         9628     9634    +6     
  Branches       751      751           
========================================
+ Hits          6139     6143    +4     
- Misses        3252     3254    +2     
  Partials       237      237           
Impacted Files Coverage Δ
django_project/core/settings/prod_docker.py 0.00% <0.00%> (ø)
django_project/core/settings/contrib.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08d62fb...4bf7c7e. Read the comment docs.

dimasciput commented 3 years ago

@sumandari any update on this?

sumandari commented 3 years ago

@dimasciput The gmail account setup for the related issue has not been completed yet.

Hi @timlinux, would you please advise whether we will continue to use the gmail-api or we will stick with the existing smpt? Thank you

timlinux commented 2 years ago

We can use the gmail API. Can you get the pr running on a local instance so that we can do a test before deploying live.