search

kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

Set embedded youtube player aspect ratio to 16:9 #1343

Closed sumandari closed 3 years ago

sumandari commented 3 years ago

This is to address #1331

1331_youtube

codecov[bot] commented 3 years ago

Codecov Report

Merging #1343 (aed5fef) into develop (08d62fb) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1343   +/-   ##
========================================
  Coverage    63.76%   63.76%           
========================================
  Files          180      180           
  Lines         9628     9628           
  Branches       751      751           
========================================
  Hits          6139     6139           
  Misses        3252     3252           
  Partials       237      237

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08d62fb...aed5fef. Read the comment docs.

dimasciput commented 3 years ago

@sumandari can you update me on this draft?

sumandari commented 3 years ago

@dimasciput The ticket requires to set ratio youtube ratio video embedded on the web page. The solution I made in this draft is only to resize the frame size with a ratio 16:9, it doesn't work on the embedded youtube video itself. I think I will close/decline this PR since it's not relevant to the issue