kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

1326 validate invalid further reading link #1347

Closed sumandari closed 3 years ago

sumandari commented 3 years ago

Please kindly see #1326 This is to address error 502 from the previous fix

image

image

codecov[bot] commented 3 years ago

Codecov Report

Merging #1347 (b258604) into develop (0fc574f) will increase coverage by 0.16%. The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1347      +/-   ##
===========================================
+ Coverage    63.76%   63.92%   +0.16%     
===========================================
  Files          180      180              
  Lines         9628     9617      -11     
  Branches       751      750       -1     
===========================================
+ Hits          6139     6148       +9     
+ Misses        3252     3228      -24     
- Partials       237      241       +4     
Impacted Files Coverage Δ
django_project/lesson/urls.py 86.66% <ø> (ø)
django_project/lesson/views/further_reading.py 69.13% <60.00%> (+16.82%) :arrow_up:
django_project/lesson/utilities.py 74.00% <100.00%> (+2.57%) :arrow_up:
django_project/changes/utils/render_to_pdf.py 76.47% <0.00%> (+29.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fc574f...b258604. Read the comment docs.

sumandari commented 3 years ago

Please test it on: https://staging.changelog.kartoza.com/en/qgis/lessons/#introduction-qgis-1

NyakudyaA commented 3 years ago

LGTM @sumandari invalid