kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

Update slug to be unique together with certifying organisation #1358

Closed sumandari closed 3 years ago

sumandari commented 3 years ago

This is to fix #1357

When user create new course type, it will create slug with 50chars max from course name.

This PR enable the different certifyng organisation to create the same course name.

sumandari commented 3 years ago

Notes:

In the issue #1375, there is an existing courseType with same slug but it has different name. I guess the existing courseType was edited with a new name, and that's why our code cannot prevent this duplication. So I think we can change the way we add counter in the slug duplication rather than change the unique value. Would you have suggestion @dimasciput?

sumandari commented 3 years ago

We are not implementing this. I will close this PR