search

kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

Fix CourseType urls patterns #1360

Closed sumandari closed 3 years ago

sumandari commented 3 years ago

Fix regex for pk in CourseType

please see sentry event: d7bad7423d7c436e905d53466f229ead

codecov[bot] commented 3 years ago

Codecov Report

Merging #1360 (298f14b) into develop (557c2fa) will increase coverage by 0.17%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1360      +/-   ##
===========================================
+ Coverage    63.98%   64.16%   +0.17%     
===========================================
  Files          180      180              
  Lines         9622     9622              
  Branches       751      751              
===========================================
+ Hits          6157     6174      +17     
+ Misses        3224     3204      -20     
- Partials       241      244       +3
Impacted Files Coverage Δ
django_project/certification/urls.py 100.00% <ø> (ø)
django_project/certification/views/course_type.py 57.73% <0.00%> (+17.52%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 557c2fa...298f14b. Read the comment docs.

sumandari commented 3 years ago

Thank you Dimas, I will merge this for now

sumandari commented 2 years ago

This fix has been released on v2.3.0 and deployed on prod