search

kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

Add github action to test PR #1361

Closed sumandari closed 3 years ago

sumandari commented 3 years ago

This PR is using docker-compose to test against PR

codecov[bot] commented 3 years ago

Codecov Report

Merging #1361 (3c046e4) into develop (e4d826a) will increase coverage by 0.12%. The diff coverage is 14.28%.

:exclamation: Current head 3c046e4 differs from pull request most recent head 31b088c. Consider uploading reports for the commit 31b088c to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1361      +/-   ##
===========================================
+ Coverage    63.94%   64.07%   +0.12%     
===========================================
  Files          180      180              
  Lines         9622     9622              
  Branches       751      751              
===========================================
+ Hits          6153     6165      +12     
+ Misses        3227     3217      -10     
+ Partials       242      240       -2
Impacted Files Coverage Δ
django_project/certification/urls.py 100.00% <ø> (ø)
django_project/certification/views/course_type.py 40.20% <0.00%> (ø)
django_project/changes/views/changelog_github.py 51.33% <0.00%> (ø)
django_project/lesson/models/specification.py 90.32% <ø> (ø)
django_project/certification/models/course_type.py 95.45% <100.00%> (+9.09%) :arrow_up:
django_project/core/settings/utils.py 100.00% <0.00%> (+50.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1baf221...31b088c. Read the comment docs.

sumandari commented 3 years ago

To test if the test against PR failed: test_always_failed.py image

lucernae commented 3 years ago

Merge my PR https://github.com/sumandari/prj.app/pull/10 first so that I can back-review it in this PR.

lucernae commented 3 years ago

Ah we don't need any token at all if it is a public repo. image

sumandari commented 3 years ago

I have got this error once: image in upload codecov steps at https://github.com/sumandari/prj.app/runs/3268591845

Ah we don't need any token at all if it is a public repo. image

Thank you @lucernae for your kind help, your valuable work and all details above.