kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

[Feature Request] Allow rephrasing of standard certificate sentences #1371

Closed andremano closed 2 years ago

andremano commented 2 years ago

The default wording certificates come with can be potentially incompatible with the internal procedures and regulations of academic (or other) institutions. In the example below, it would be easier internally if the wording could be changed to Has attended the course intead of the current Has attended and completed the course. image

Adding the possibility of changing some of the default wording solves the issue. In order to avoid the risk of making the certificates too unstandardized it might be a bad idea to just leave it totally customizable. Therefore, I suggest that each these sentences are added to a list from where to choose from if (A) a request with a the specific sentence comes from a certifying organization (like in this concrete case) and (B) the wording is approved by the QGIS certification program team.

jvdkwast commented 2 years ago

Indeed different certificate types are used. In my work I only see "Certificate of Attendance" and "Certificate of Completion". I don't know if there are other ones. But having a list also has my preference instead of a free field.

andremano commented 2 years ago

Thank you for your feedback @jvdkwast. @sumandari Is my suggestion something that can be implemented?

sumandari commented 2 years ago

Thank you for your input @andremano @jvdkwast. Regarding implementation in the code, yes, I think we can put a dropdown list to choose the certificate type in the course. From @jvdkwast, we have got "Certificate of Attendance" and "Certificate of Completion" as option in the list. And possibly we will add (if there's any) another type in the future. Would you please suggest how to propose the wording (or ask suggestion) to QGIS certification program team? cc @timlinux

andremano commented 2 years ago

In addition to the cerrificate type (Certificate of attendance OR Certificate of Completion), my suggestion is for now to also add a dropdown list with two wording options:

1 - Has attended and completed the course (the current default) 2 Has attended the course

timlinux commented 2 years ago

Part 1

Create a new model for certification course types and an admin page for creating / deleting types

Part 2

In the certification menu add a place for certification managers to manage the list of certificate types. Only certification managers can see this menu.

image

Part 3

Setting the attendance type on teh course: https://changelog.qgis.org/en/qgis/certifyingorganisation/qgis-kartoza-pty-ltd/course/qgis_introduction-qgis-online_2021-08-02-2021-08-04/update/

image

Can default to existing wording so previously created courses use the same wording

Part 4

Update the template to get the certification type text from the course model

andremano commented 2 years ago

Thanks @timlinux - What you describe is pretty much what I had in mind when I opened this issue.

andremano commented 2 years ago

Poking this issue - I take it from the discussion that these changes have a green light and will be implemented?

sumandari commented 2 years ago

@andremano This feature has been fixed in v2.3.0 and deployed on prod. I will close it for now

andremano commented 2 years ago

Thank you for this! Really appreciate it. Now, I assume that in order to add the terminology option has attended, I first have to request it to be listed and approved by @jvdkwast ? Is it so?

sumandari commented 2 years ago

For adding the Certificate Type with wording has attended, the admin can add the instance in admin page: image

image

For adding the Certificate Type in a project, the Certification Manager can go to Manage Certificate Type in Certification menu and check the checkbox to choose image

I will re-open the ticket for the has attended certificate wording implementation in the platform

cc @timlinux @dimasciput

andremano commented 2 years ago

Thanks, @sumandari. I think having an admin approve/add a terminology first is a wise approach in order not to lose certificate consistency. I will wait then for an admin to do it.

andremano commented 2 years ago

@jvdkwast could you please add the 'Has attended' to the list of allowed terminologies?

jvdkwast commented 2 years ago

@andremano This is a task for the developers. I'm not able to edit the list. @sumandari

sumandari commented 2 years ago

@andremano @jvdkwast I have added 'Has attended' in Certificate Type model.

image

Now the Certification Managers can apply this certificate type into the project by checking the checkbox and clicking on the Save button. @jvdkwast would you please check if you can check and save the Certificate Type in Certification >> Manage Certificate Type? Thank you

jvdkwast commented 2 years ago

@sumandari Yes that works.

jvdkwast commented 2 years ago

Thanks. Just a few questions: So in this case for example @andremano is the Certification Manager and can change the settings for his organisation here by himself? And for adding other Certification Types to the list we can contact the developers, right?

sumandari commented 2 years ago

Yes, If @andremano is the Certification Manager, he can change the Certificaye Type for the project. Later on, the Certifying Organisation can choose the type of the certificate for their courses in their settings. To add new Certificate Type, we can contact admin/ super user account to add via django admin page.

andremano commented 2 years ago

@sumandari I am sorry to keep extending this thread, but I am very confused about what I have to do. I do not have access to a 'Certificate type' menu unless I type to URL directly, but there, if I check the 'Has attended' option nothing happens. I guess this happens because I am the organization owner but not a 'Certification Manager'. How do I assign that role to myself?

sumandari commented 2 years ago

@andremano if you are not a Certification Manager so you should not be able to update the certificate type list, but you can update your certification type in your course. You are not supposed to be able to access the URL as well if you are not a Certification Manager. I will create a ticket to fix this. Once a new Certificate Type has been added in a project (in this case is QGIS), all QGIS courses will have the new Certificate Type in Certificate type* drop-down input.

Please go to your course, create or edit course.

image image

To update the wording in existing generated PDF, please re-generate PDF:

image

ps. I saw earlier that the Certificate Type for Has attended hasn't been checked yet, so I checked it to enable this certificate type in QGIS courses. cc @jvdkwast @timlinux

andremano commented 2 years ago

@sumandari Ah yes! I see it now. Thank you so much for supporting this. I am sorry for having dragged you into this long thread @jvdkwast.