Codecov Report

Merging #1375 (0e1a285) into develop (bfab4ac) will increase coverage by 0.13%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1375      +/-   ##
===========================================
+ Coverage    64.29%   64.42%   +0.13%     
===========================================
  Files          180      180              
  Lines         9664     9665       +1     
  Branches       758      758              
===========================================
+ Hits          6213     6227      +14     
+ Misses        3207     3195      -12     
+ Partials       244      243       -1

Impacted Files	Coverage Δ
django_project/certification/forms.py	`59.37% <ø> (+0.34%)`	:arrow_up:
...ect/certification/views/certifying_organisation.py	`49.52% <ø> (ø)`
...go_project/certification/models/course_convener.py	`92.30% <100.00%> (+2.83%)`	:arrow_up:
django_project/certification/views/course.py	`80.00% <0.00%> (+5.64%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bfab4ac...0e1a285. Read the comment docs.

timlinux commented 2 years ago

Thanks - will you make another ticket in our backlog to review all models and prevent cascading deletions. As a genera approach we should archive entities when they are deleted rather than deleting them.

timlinux commented 2 years ago

LGTM thanks!

kartoza / prj.app

Add Mechanism to Delete Course Converner #1375

Demo convener has courses related to organization

Demo delete Convener that has no course related with the organization

Codecov Report