kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

Add Certificate Type #1383

Closed sumandari closed 2 years ago

sumandari commented 2 years ago

Please see #1371

codecov[bot] commented 2 years ago

Codecov Report

Merging #1383 (f2254ea) into develop (b2895c7) will increase coverage by 0.22%. The diff coverage is 97.18%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1383      +/-   ##
===========================================
+ Coverage    64.52%   64.74%   +0.22%     
===========================================
  Files          180      182       +2     
  Lines         9703     9773      +70     
  Branches      1232     1242      +10     
===========================================
+ Hits          6261     6328      +67     
- Misses        3194     3195       +1     
- Partials       248      250       +2     
Impacted Files Coverage Δ
django_project/certification/urls.py 100.00% <ø> (ø)
...go_project/certification/views/certificate_type.py 94.73% <94.73%> (ø)
django_project/certification/admin.py 61.53% <100.00%> (+2.77%) :arrow_up:
django_project/certification/forms.py 59.51% <100.00%> (+0.14%) :arrow_up:
django_project/certification/models/__init__.py 100.00% <100.00%> (ø)
...o_project/certification/models/certificate_type.py 100.00% <100.00%> (ø)
django_project/certification/models/course.py 90.76% <100.00%> (+0.29%) :arrow_up:
django_project/certification/views/__init__.py 100.00% <100.00%> (ø)
django_project/certification/views/certificate.py 53.05% <100.00%> (+0.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2895c7...f2254ea. Read the comment docs.

sumandari commented 2 years ago

Demo:

Only super users and certification managers can access certification types menu

https://user-images.githubusercontent.com/40058076/147897606-ca3c16c9-8660-4a8b-aba0-4152bcb4a04f.mp4


Manage certificate types to be enabled on the projects

https://user-images.githubusercontent.com/40058076/147897607-8dbe7753-0035-4523-b8ed-05b626008cc9.mp4


dimasciput commented 2 years ago

LGTM please merge @sumandari