search

kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

Fix certificate type view permission #1403

Closed sumandari closed 2 years ago

sumandari commented 2 years ago

Please see: #1402

Problem: Normal user can access the certificate type via url

Proposed solution: Check if user is staff or certification manager in dispatch method

codecov[bot] commented 2 years ago

Codecov Report

Merging #1403 (e26c346) into develop (28560c6) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1403      +/-   ##
===========================================
+ Coverage    64.74%   64.78%   +0.03%     
===========================================
  Files          182      182              
  Lines         9773     9779       +6     
  Branches      1242     1243       +1     
===========================================
+ Hits          6328     6335       +7     
  Misses        3195     3195              
+ Partials       250      249       -1
Impacted Files Coverage Δ
...go_project/certification/views/certificate_type.py 97.72% <100.00%> (+2.99%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 28560c6...e26c346. Read the comment docs.