search

kartoza / prj.app

A django app for creating visual changelogs for software releases
30 stars 32 forks source link

GH PR parser - Use links in markdown for funders #1439

Open Gustry opened 1 year ago

Gustry commented 1 year ago

It happens often. This test case should be covered.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1439 (ba900fe) into develop (b9fc0ce) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1439   +/-   ##
========================================
  Coverage    64.22%   64.22%           
========================================
  Files          179      179           
  Lines         8800     8800           
  Branches      1258     1258           
========================================
  Hits          5652     5652           
  Misses        2866     2866           
  Partials       282      282

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Gustry commented 1 year ago

Ah, tests are already passing ? But the logs in the GH Action shows it failed ! https://github.com/kartoza/prj.app/runs/8111351705?check_suite_focus=true#step:8:932

@dimasciput This looks dangerous FYI.

dimasciput commented 1 year ago

@Gustry thanks for noticing, I will check this issue when I'm back from leave. Did you make this PR while resting from your bike trip? 😄