kartoza / rezoning-2-project

Rezoning project organizational repository
Creative Commons Zero v1.0 Universal
0 stars 4 forks source link

Epic 5 (Discovery): Interactive Filtering #12

Closed NEDJIMAbelgacem closed 1 year ago

NEDJIMAbelgacem commented 1 year ago

Note that discovery tasks will be completed by order of priority in line with discovery task requirements. Discovery may include documentation and/ or implementation of feature design.

Expectation:

Interactive filtering options display the effects of filter values on the outputs

Priority:

Medium

Dependencies:

None

Description:

Current filtering options are limited and can only be reviewed by issuing server requests and updating with a button-press, which retrieves updated outputs from the backend services. This task would be to outline and possibly implement a solution for either demonstrating the effect of individual layer filtering, or "on-the-fly" filtering which is reactive and directly demonstrates the implications of each of the individual filters on data.

Scope:

The scope of this process will depend on the results of the discovery process.

Requirements:

None

Success Criteria:

Users are able to visualise the effects of their individual filter values

NEDJIMAbelgacem commented 1 year ago

Hi @ClaraIV & @gclapp1 I had thought about this: Currently the filtering results are displayed only when the zone scores are calculated by pressing the generate zones buttons. I would suggest that we keep the zone calculation only happening when we press the "generate zones" button. But for the filtering, we have the "suitable areas" raster that is displayed to indicated zones that are filtered out. I suggest that at the bottom of the filters we add a button saying "apply filters" and a check box for auto applying the filtering. This will make sure the "suitable areas" layer is displayed on the map and will make it easier to find out which zones are filtered out and will have the benefit of viewing the area of interest dynamically without the delay of waiting for each zone score to generated. Let me know what you think so I can start implementing this feature.

ClaraIV commented 1 year ago

I am not sure I understand this, I suggest we discuss it in the team meeting before you proceed with any implementation

ClaraIV commented 1 year ago

I am not sure this works as expected.

Please see below Angola_onshore wind: nothing is displayed

Image

The same value range/ same parameters show a complete raster on the published tool:

Image

ClaraIV commented 1 year ago

furthermore, I believe that the filtering resulted in other bugs, as the results the tool generate now are radically different (almost not filtered at all) than what we obtain using the original tool. Please see the new tickets on the matter

ClaraIV commented 1 year ago

I don't see the "Distance to" layers being displayed, is this still in the works?

NEDJIMAbelgacem commented 1 year ago

I don't see the "Distance to" layers being displayed, is this still in the works?

This has been addressed

ClaraIV commented 1 year ago

@akshay2408 @dimasciput I still do not see that this is working properly. please see below. For offshore wind -Romania, the Wind Speed filter (>7m/s) shows no data; however, I know for a fact there are 2 areas with wind speed >7m/s and this is resulted also from running the tool, please see the results in pink with the same wind speed filter.

Image

Image

akshay2408 commented 1 year ago

Hi @ClaraIV Could you please check this again. I just checked and I think the area is visible, also in 1st screenshot we have zone type as Boundaries and resource is Offshore. But last week in one of the ticket https://github.com/kartoza/rezoning-2-project/issues/5 we removed the Boundaries option for offshore.

LunaAsefaw commented 1 year ago

@akshay2408 @dimasciput I still do not see that this is working properly. please see below. For offshore wind -Romania, the Wind Speed filter (>7m/s) shows no data; however, I know for a fact there are 2 areas with wind speed >7m/s and this is resulted also from running the tool, please see the results in pink with the same wind speed filter.

Image

Image

Hi @ClaraIV , I just wanted to get clarification on this issue. When I check for offshore wind and the range is 7 to 7.76, I get the two areas but when I change my wind speed to 8-9, no data is returned. Is the issue that no areas are returned for 7-7.76 (which returns areas currently) or that no areas are returned for wind speed > 7

LunaAsefaw commented 1 year ago

@ClaraIV I was going through the Rezoning user guide and saw this. image

Let's say you chose solar for Afghanistan and you set the filters to specific values, then decide you want to assess Albania, should the parameter values change or should they be the same values you had for Afghanistan and user can click on reset value to get default values for Albania?

ClaraIV commented 1 year ago

@LunaAsefaw RE your previous comment: the range of value >7 generates results; that means that I should be able to see the offshore wind resource layer with the filter set value>7 at tool initiation phase; this is what I tested and failed; please let me know if this is clear

RE your last comment, that seems fine, and it is not connected to the use case I presented;

LunaAsefaw commented 1 year ago

@ClaraIV When I use the parameters you used (25km) I also get 2 suitable areas, See below: image

Additionally, when I change the zone size to 50 Km, I also get two suitable areas: image

The image you sent that has no areas returned uses boundaries for the zone type and we said if offshore wind is selected, boundary is not an option so offshore data only has 25 or 50 km as the options. In fact even if I wanted to test it, I couldn't because boundaries was removed from the options for the users to select.

RE the second comment, I saw this in the user guide but I don't think that is how the system is built. If I changed countries, the inputs change to the minimum and maximums relating to the changed country. So my concern is, what method is preferred? The document mentions using the maximum and minimums as the range but also mentions keeping inputs when countries are changed, which is conflicting.

ClaraIV commented 1 year ago

@LunaAsefaw , you are missing the point - the point is that the tool should show the wind speed (the resource layer) upon tool initiation - forget the unit of analysis from my 2nd screenshot, it is not important and I did it quickly for demonstration. Perhaps it is better to leave this ticket for discussion in the team meeting

LunaAsefaw commented 1 year ago

Detailed outcome testing found under #73

ClaraIV commented 1 year ago

@LunaAsefaw the Land Use/Land Cover filter doesnt seem to work, it doesnt display any data - can you kindly check? This layer should have been updated with the latest dataset, we provided a link to that - I wonder if there's a bug in its ingestion

image

LunaAsefaw commented 1 year ago

Thanks for picking this up, my apologies for not noticing @ClaraIV. I played around a bit to see what the issue is so we have a clear problem statement for @dimasciput and found the following: So when I deactivate the toggle, all the land covers found in the dropdown list are included so it shows this: image

Then I switch the toggle on and nothing shows, as seen in Clara's screenshot above. I thought it is because the land covers found are not selected in the list but when I see the list, water bodies and urban areas are selected and were actually found in the area yet they do not return anything. image

Then I selected every landcover on the dropdown list and then the toggle worked image

So the bug with this function is that it does not allow selection of specific land covers, it only displays either all the land covers or none.

ClaraIV commented 1 year ago

I actually think the classes are filtered out, if they wouldnt be filtered, the entire area would be covered. Since we see patches of empty land, that means that the filter is working. If there would be “no data”, black pixels would be displayed. @dimasciput

On Thu, Jun 8, 2023 at 10:41 AM Luna @.***> wrote:

Thanks for picking this up, my apologies for not noticing @ClaraIV https://github.com/ClaraIV. I played around a bit to see what the issue is so we have a clear problem statement for @dimasciput https://github.com/dimasciput and found the following: So when I deactivate the toggle, all the land covers found in the dropdown list are included so it shows this: [image: image] https://user-images.githubusercontent.com/90245715/244299606-8362ec57-3364-4488-bd9c-60722ea41688.png

Then I switch the toggle on and nothing shows, as seen in Clara's screenshot above. I thought it is because the land covers found are not selected in the list but when I see the list, water bodies and urban areas are selected and were actually found in the area yet they do not return anything. [image: image] https://user-images.githubusercontent.com/90245715/244301507-6d22d6ea-f10e-41e1-9159-c2ccc030801f.png

Then I selected every landcover on the dropdown list and then the toggle worked [image: image] https://user-images.githubusercontent.com/90245715/244300718-4b92457b-72ae-4ec5-be9a-2db747e1b603.png

So the bug with this function is that it does not allow selection of specific land covers, it only displays either all the land covers or none.

— Reply to this email directly, view it on GitHub https://github.com/kartoza/rezoning-2-project/issues/12#issuecomment-1582063971, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHU3HIYBAYWTFIT4IYJ77TXKF6Z5ANCNFSM6AAAAAASGVGYW4 . You are receiving this because you were mentioned.Message ID: @.***>

ClaraIV commented 1 year ago

You can have a look st the ESA land cover dataset online, they have a web app and you can visualize each country to see how it should look with all the classes selected. This can give you an idea on how the filter is working

On Thu, Jun 8, 2023 at 10:47 AM Clara Ivanescu @.***> wrote:

I actually think the classes are filtered out, if they wouldnt be filtered, the entire area would be covered. Since we see patches of empty land, that means that the filter is working. If there would be “no data”, black pixels would be displayed. @dimasciput

On Thu, Jun 8, 2023 at 10:41 AM Luna @.***> wrote:

Thanks for picking this up, my apologies for not noticing @ClaraIV https://github.com/ClaraIV. I played around a bit to see what the issue is so we have a clear problem statement for @dimasciput https://github.com/dimasciput and found the following: So when I deactivate the toggle, all the land covers found in the dropdown list are included so it shows this: [image: image] https://user-images.githubusercontent.com/90245715/244299606-8362ec57-3364-4488-bd9c-60722ea41688.png

Then I switch the toggle on and nothing shows, as seen in Clara's screenshot above. I thought it is because the land covers found are not selected in the list but when I see the list, water bodies and urban areas are selected and were actually found in the area yet they do not return anything. [image: image] https://user-images.githubusercontent.com/90245715/244301507-6d22d6ea-f10e-41e1-9159-c2ccc030801f.png

Then I selected every landcover on the dropdown list and then the toggle worked [image: image] https://user-images.githubusercontent.com/90245715/244300718-4b92457b-72ae-4ec5-be9a-2db747e1b603.png

So the bug with this function is that it does not allow selection of specific land covers, it only displays either all the land covers or none.

— Reply to this email directly, view it on GitHub https://github.com/kartoza/rezoning-2-project/issues/12#issuecomment-1582063971, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHU3HIYBAYWTFIT4IYJ77TXKF6Z5ANCNFSM6AAAAAASGVGYW4 . You are receiving this because you were mentioned.Message ID: @.***>

LunaAsefaw commented 1 year ago

The issue has been fixed, when I just click on the 'show' icon, the land cover shows

Image

If I add more land cover options from the drop down, it adds and displays without issues. See below, initially water bodies was not selected and now that it is, it is displayed

Image

Lastly, when the toggle is switched off, all the layers are displayed successfully

Image

Additionally, the interactive filtering issue seen with selecting UNESCO (reported in #13) is fixed

Image