Closed NEDJIMAbelgacem closed 1 year ago
Hi @ClaraIV this issue is fixed and now everything is clipped properly:
Also as it turns out this might have had some effect on the calculation results because the calculations on a zone before were done on the convex hull of the area's polygon not on the polygon itself which resulted in some extra data being accounted for that doesn't belong to the area.
@NEDJIMAbelgacem to ensure land pixels are masked out
Specific issues identified:
Luna to work through each and compile a list of issue areas.
For the countries that are not delivering results: Chile and Caspian sea, it is the filters filter out all the areas because of a likely missing layer's data
I created a new ticket for the pixel level clipping as this ticket is actually fixed for larger areas: https://github.com/kartoza/rezoning-2-project/issues/56
It would be good to be sure, and not operate on guesses. Does the original tool show results for these 2 areas? Please always compare with original tool results
On Mon, Apr 10, 2023 at 9:48 AM Nedjima Belgacem @.***> wrote:
For the countries that are not delivering results: Chile and Caspian sea, it is the filters filter out all the areas because of a likely missing layer's data
— Reply to this email directly, view it on GitHub https://github.com/kartoza/rezoning-2-project/issues/40#issuecomment-1501465443, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHU3HN7VJP4AQERCCVRYQDXAOULNANCNFSM6AAAAAAVCVYTSU . You are receiving this because you were mentioned.Message ID: @.***>
this has not been resolved @akshay2408
Hi @ClaraIV I have read the comments but could you please conclude what I have to do in this ticket. I saw belgacem created one more ticket #56.
Hi @akshay2408 if it;s not clear from the comments I dont think I can help further through additional comments, let us discuss in our meeting; please focus on other tickets until then - thanks!
@gclapp1 @akshay2408 @LunaAsefaw RE our discussion in the meeting, just re-ran Caspian Sea on the old tool and it works; the results are as expected from past project work.
Hi @ClaraIV When I increase the anchorage distance to the full range, we also get results on the staging site, so the only reason the production site generates results but the staging site did not is due to the default values being different, would you like us to change the default values in this situation?
hi @LunaAsefaw , thanks for catching this - the default values should be identical on the deployed site and the staging site, not sure how/why they changed - please double check that the default values from the deployed site are reflected 100% in the staging site - those were chosen after consultations with experts from all 3 sectors. Thanks!
Tested and findings were in-line with what was discussed in last week's meeting: some of the off-shore value ranges on the deployed site are higher or lower due to improper clipping of countries and regions.
Thanks, closing ticket
one obvious consequence of this is the results of analysis for Offshore Wind, which shows suitable areas on land. see below an example; the expectation is to have resulting areas only in the sea, not on land