kartoza / rezoning-2-project

Rezoning project organizational repository
Creative Commons Zero v1.0 Universal
0 stars 4 forks source link

Grid/ Boundary Selection [Epic 3] #5

Closed NEDJIMAbelgacem closed 1 year ago

NEDJIMAbelgacem commented 1 year ago

grid-selection

Expectation:

Allow users to select between grid/boundary after the selection of the resource, in a separate pop-up panel.

Dependencies:

None

Description:

When initiating the application, the interface prompts users to select a country in a pop-up panel (modal window). Once a country is selected, the user is then prompted in a new modal for resource selections. It is desired that this process be extended to allow users to specify whether they wish to restrict the current operation to the grid or boundary definition in a pop-up window.

Scope:

This task will create a new modal window with two buttons that allow the state definition in a manner that is a replication of the functionality in the existing filtering options.

Out of scope:

Modification to the existing filters or interfaces.

Requirements:

None

Success Criteria:

A third pop-up window for grid or boundary selection when initiating the application

NEDJIMAbelgacem commented 1 year ago

Addressed in https://github.com/worldbank/WB-rezoning-explorer/pull/2
Ping @ClaraIV & @gclapp1 let me know your feedback

gclapp1 commented 1 year ago

Instead of two buttons, in my computer's UI, I see three-screenshot included below. The same interface appears for on-shore wind, solar and off-shore wind.

Image

NEDJIMAbelgacem commented 1 year ago

Hi @gclapp1 , Do u want it to be the UI to be the same as before but with the pop up of the resource selection panel? grid-admin-reg

ClaraIV commented 1 year ago

I appreciate the 3 buttons, as it gives the user all the options it has, from starts; the same window can then be selected from within the tool, if results want to be re-run at different aggregation size, so we dont need to worry about a different view there or whether the user will find it confusing to have different views. I am fine with the current implementation Belgacem did. I do think we should remove the >boundaries> option from Offshore, as this refers to outside country borders -> it also doesnt generate any results, it freezes (I just tested it)

NEDJIMAbelgacem commented 1 year ago

Hi @ClaraIV I made sure that the boundaries option is not selectible for offshore resource last week (it is on staging also). Let me know if I need to change anything.

ClaraIV commented 1 year ago

looks good to me!

ClaraIV commented 1 year ago

@akshay2408 @dimasciput There is a bug related to this ticket that I just discovered. Offshore Wind should not allow the selection "boundaries". However, when you select a country -> solar/wind-> boundaries and then change the technology to "offshore wind", the area of analysis does not change and you can run the tool with "offshore wind" - "boundaries" which runs in an infinity loop. This shouldn't be allowed and the area of analysis should automatically change to either grid size

Image

akshay2408 commented 1 year ago

Okay @ClaraIV and @dimasciput got it, I will work on it.

ClaraIV commented 1 year ago

awesome! thanks!