kartoza / rezoning-2-project

Rezoning project organizational repository
Creative Commons Zero v1.0 Universal
0 stars 4 forks source link

LCOE legend #57

Closed ClaraIV closed 1 year ago

ClaraIV commented 1 year ago

LCOE values are not reflected in LCOE legend -> no variation in pixel coloring on the map

Image

NEDJIMAbelgacem commented 1 year ago

Actually this problem wasn't from the legend itself but because for LCOE layer we have a fixed range for values [80, 300] and with that range in some cases no (or more accurately too little) color variation show up on the map. This issue has been fixed Before: lcoe-before After: lcoe-updated

ClaraIV commented 1 year ago

nicely done! I've tested it for couple countries and it looks good! One thing I noticed for Offshore Wind is that the layer is under the EEZ layer, making it hard to see; can you move it on top of all other layers? @NEDJIMAbelgacem

image

ClaraIV commented 1 year ago

@akshay2048

akshay2408 commented 1 year ago

Hi @ClaraIV could you please explain this from above comment of yours One thing I noticed for Offshore Wind is that the layer is under the EEZ layer, making it hard to see; can you move it on top of all other layers? When does it occurs or how to reproduce it?

ClaraIV commented 1 year ago

hi @akshay2408 , I also included a screenshot - is that not visible? It shows exactly what I expressed in writing. You can also test it yourself -> run the tool for a country for Offshore and (for comparison) for Onshore and compare the result in display for the LCOE layer. You can also compare the 2 screenshots in my message and Belgacem's message above and notice the difference in the display of the layer, which make the difference very obvious..

akshay2408 commented 1 year ago

Hi @ClaraIV here is the updated UI is it Correct ?

Screenshot 2023-04-26 at 4 40 19 PM
ClaraIV commented 1 year ago

@akshay2408 , i simply asked for a change in the order of the spatial layers overlay, meaning to display first the LCOE layer on top of the EEZ border (the transparent polygon) so that it looks similar to the other technologies. This doesnt look good, there is no variation in the LCOE layer color at all, please revert all changes to what Belgacem implemented for the LCOE layer and simply focus on the drawing order of the files

akshay2408 commented 1 year ago

okay @ClaraIV I have not deployed these changes to staging. They are only in my local machine, so I will do the suggested changes.

akshay2408 commented 1 year ago

@dimasciput Please review this PR https://github.com/worldbank/WB-rezoning-explorer/pull/27

akshay2408 commented 1 year ago

Hi @ClaraIV here is the updated UI. Please let me know if it is correct.

Screenshot 2023-05-02 at 12 44 41 PM
ClaraIV commented 1 year ago

thanks, this works well!