search

kartoza / rezoning-2-project

Rezoning project organizational repository
Creative Commons Zero v1.0 Universal
0 stars 4 forks source link

Zone Analysis Window #59

Closed ClaraIV closed 1 year ago

ClaraIV commented 1 year ago

The Zone Analysis Window should be closed at Tool initiation, as it takes space from the screen; The window should appear on the right side once the user clicks "Generate Zones" button

Image

akshay2408 commented 1 year ago

@NEDJIMAbelgacem this is the PR for this Task https://github.com/worldbank/WB-rezoning-explorer/pull/21

ClaraIV commented 1 year ago

@akshay2408 @dimasciput The results window should restart when user changes technology or country, no? To test: run Solar for any country, then change to Wind -> the results from the previous analysis remain; perhaps the window can be closed at least, if not restarted?

Image

akshay2408 commented 1 year ago

@akshay2408 @dimasciput The results window should restart when user changes technology or country, no? To test: run Solar for any country, then change to Wind -> the results from the previous analysis remain; perhaps the window can be closed at least, if not restarted?

Image

Hi @ClaraIV I have done this and raised PR.

ClaraIV commented 1 year ago

@akshay2408 this works fine! Can you please also close the Contextual Layers window upon the same change? Since it is displaying access to results, it should have the same behaviour as the Zone Analysis window

LunaAsefaw commented 1 year ago

Hi @gclapp1, I see that this issue has been moved to Backlog after being accepted. Please provide more details on the issue so we can fix it

gclapp1 commented 1 year ago

Hi @LunaAsefaw, I misinterpreted Clara's comment and thought she was asking for it to be closed upon launch of zone scores.

Accordingly, closing this ticket-thanks for following up.