Update tour guide - Githubissues

kartoza / rezoning-2-project

Rezoning project organizational repository

Creative Commons Zero v1.0 Universal

0 stars 4 forks source link

Update tour guide #61

Closed NEDJIMAbelgacem closed 1 year ago

NEDJIMAbelgacem commented 1 year ago

Tour updates: Info box, interactive filtering, layer visualization, import/export/ user feedback

akshay2408 commented 1 year ago

@NEDJIMAbelgacem this the PR for this Task https://github.com/worldbank/WB-rezoning-explorer/pull/24

ClaraIV commented 1 year ago

@akshay2408 Step6 needs to be re-written, as we have moved many of the contextual layers out of the legend. Please update to: "Toggle contextual layers to visualize the resulting output on the map and additional relevant spatial data"

Step7 - does not download 3 CSVs, but 1 CSV per window (Spatial/ Economic/ Weights) Therefore please update text to: "Export Tour 7 / 10 Click here to download the input parameters and associated thresholds in CSV format"

Step 8 Import Tour 8 / 10 You can import previously saved input parameters in CSV format"

Step 10 should come before Step 9 -> Step 9 (to re-open the guide when needed) should be last. Step 10-update text to: " You can use the Feedback Form to report any bugs or give suggestions for improvements" Step 10 is not fully visible, the box does not adjust to screen size:

akshay2408 commented 1 year ago

Hi @ClaraIV you mentioned this Step 10 is not fully visible, the box does not adjust to screen size: So because zone analysis window is closed initially so that is why tour step is not fully visible. Please suggest, do I only need to adjust the tour box size OR I need to show zone analysis window as well.

ClaraIV commented 1 year ago

my comment is solely for the box that is not visible

On Wed, 10 May 2023 at 11:46, akshay2408 @.***> wrote:

Hi @ClaraIV https://github.com/ClaraIV you mentioned this Step 10 is not fully visible, the box does not adjust to screen size: So because zone analysis window is closed initially so that is why tour step is not fully visible. Please suggest, do I only need to adjust the tour box size OR I need to show zone analysis window as well.

— Reply to this email directly, view it on GitHub https://github.com/kartoza/rezoning-2-project/issues/61#issuecomment-1541597348, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACHU3HIQ334JFG462ZLTC63XFNIU7ANCNFSM6AAAAAAWY7R5II . You are receiving this because you were mentioned.Message ID: @.***>

akshay2408 commented 1 year ago

@ClaraIV for feedback it goes inside the zone analysis panel, but it is hidden. So user cannot see the feedback form step.

ClaraIV commented 1 year ago

oh, I see what you mean! Is it possible that the Results Window opens with this step and then closes back up?

akshay2408 commented 1 year ago

Hi @ClaraIV I debugged this issue and found that it is little difficult because tour box overlaps with zone analysis window. So I have a solution for it and I implemented it for testing.

We can open zone analysis window before tour guide reaches to it (open it one step before it reaches to zone window)
And when user clicks on Finish it will be closed.

ClaraIV commented 1 year ago

I think that sounds good! Does the Tour contain a step to present the Zone Analysis window also? It might be good to re-arrange the steps so that both the window and the feedback form are presented at the same time; if not, perhaps let's add it?

akshay2408 commented 1 year ago

okay done