Handle generic boundaries in movement alerts

kartoza / watchkeeper

A security alerts platform for iMMAP

Other

1 stars 10 forks source link

Handle generic boundaries in movement alerts #68

Closed cchristelis closed 9 years ago

cchristelis commented 9 years ago

Hi @ismailsunni, could you please review this. I made quite some changes to get this working and would appreciate an extra pair of eyes.

ismailsunni commented 9 years ago

Suggestions:

[x] Need admin page for the new model.

[x] Error when changed the country dropdown (from Chrome DevTools):

500: ProgrammingError at /get_country/
column event_mapper_movement.boundary_type_id does not exist
LINE 1: ...level", "event_mapper_movement"."movement_state", "event_map...

cchristelis commented 9 years ago

Have you run the migrations?

cchristelis commented 9 years ago

I'll add the admin page change views.

ismailsunni commented 9 years ago

Yes, I have run the migration

ismailsunni commented 9 years ago

[x] Does each province have their own movement?
[x] Changing a country's movement also change a whole country movement (all provinces). Is this expected?
[x] Changing a province's movement, doesn't seem have an effect even there is a success message.

cchristelis commented 9 years ago

@ismailsunni, those are actually symptomatic of the fact that the province's state is not being shown on the field.

cchristelis commented 9 years ago

@ismailsunni, thanks for the feedback, I have incorporated your comments.