[2.1.x custom build]: 505: does not display custom Standby text

[GoogleCodeExporter]

PRS-505  PRS+ 2.1.0 ? (Installer created with the latest data from the 
repository)

In "Standby / Shutdown Image> Image Standby" the combination:
Standby Image type:          Current book cover (and Random Image)
Display Icon on Standby:     Yes
Custom text Display Standby: Yes

It does not work. Do not display the custom text and displays a white line.

Other combinations of image, icon and text, work well.

Original issue reported on code.google.com by surkizu@gmail.com on 1 Dec 2011 at 12:28

Attachments:

• DSC06769.JPG

[GoogleCodeExporter]

Original comment by msukhias...@gmail.com on 1 Dec 2011 at 12:20

• Changed title: [2.1.x custom build]: 505: does not display custom Standby text

[GoogleCodeExporter]

Thank you for reporting. I've spotted the bug, will push a fix later today.

Original comment by quisvir on 1 Dec 2011 at 1:31

• Changed state: Started

[GoogleCodeExporter]

quisvir,

if you do so, please do me a favor and correct:
line 185
                if (!standbyImage.color && mode !=== 'act_page') {
Thanks 
Mark

Original comment by Mark.N...@gentlemansclub.de on 1 Dec 2011 at 3:08

[GoogleCodeExporter]

Sure Mark, thanks for spotting that. I guess !=== would mean 'extremely unequal 
to' ;)

Original comment by quisvir on 1 Dec 2011 at 3:20

[GoogleCodeExporter]

I see now you didn't mean there was a typo in the code, but to add the second 
part. Will do!

Original comment by quisvir on 1 Dec 2011 at 3:29

[GoogleCodeExporter]

!== means "compare but don't try to do type convertion", e.g.:
1 !== "1" => true
1 != "1" => false

Original comment by msukhias...@gmail.com on 1 Dec 2011 at 3:54

[GoogleCodeExporter]

I know; the typo was !===, so one equal-sign too many.

Original comment by quisvir on 1 Dec 2011 at 4:04

[GoogleCodeExporter]

Fixed in Revision 6f59f7e577cd.

Original comment by quisvir on 1 Dec 2011 at 4:27

• Changed state: Fixed

[GoogleCodeExporter]

Thanks,
current-page "sleeping.." in landscape mode, works now as excpected,
but just to note it: with current-page as standbyImage, the custom-text option 
isn't triggerd. Not sure bug or feature?

PS: Yes the third "=" was a typo (but you can't edit those da**d comments here.

Original comment by Mark.N...@gentlemansclub.de on 1 Dec 2011 at 7:13

[GoogleCodeExporter]

That was intended; I figured people using current-page might want to see the 
current page number in addition to the page itself.

Original comment by quisvir on 1 Dec 2011 at 8:44