search

karupanerura / TOML-Parser

simple toml parser
Other
15 stars 6 forks source link

Parser fails on inline tables #5

Closed lucab closed 8 years ago

lucab commented 8 years ago

I think this is strictly related to #2, but at the moment this is my biggest blocker.

The parser currently fails on inline tables. Even the example ones

name = { first = "Tom", last = "Preston-Werner" }
point = { x = 1, y = 2 }

fail with a

Syntax Error: line:1
name = { first = "Tom", last = "Preston-Werner" }
      ^

Can you please make the parser aware of inline tables? For your convenience, a large and updated corpus of TOML test sample is being maintained here.

karupanerura commented 8 years ago

Thank you for reporting. This module's current support version is v0.2.0. (https://github.com/toml-lang/toml/blob/master/versions/en/toml-v0.2.0.md#datetime) I'll be support it on #2. Please wait it. (or patches welcome)

lucab commented 8 years ago

Thanks for the quick answer! Yes I guessed this was a version mismatch, but I reported anyway as it is the main blocker for a Debian packaging helper script.

Unfortunately I'm not an advanced enough perl-coder to touch a module internals.

karupanerura commented 8 years ago

oh! I think your problem is very important. OK. I preferentially start #2. I can't promise, but I'll implement the v0.4.0 in tomorrow. (but, I can't promise it.)

lucab commented 8 years ago

Don't worry, no hurry. I'll just keep tracking this.

karupanerura commented 8 years ago

Done. You can try on feature/0.4 branch.

karupanerura commented 8 years ago

merged

karupanerura commented 8 years ago

Released it as version 0.6 to CPAN.

lucab commented 8 years ago

Thanks for the prompt reaction. This is so far working very well for all the TOML manifests I had to parse so far. I'll report back if I encounter further issues, but for the moment this works perfectly for me.